Bug 105816 – [EFL][WebGL] Add compile time support for GLES2.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Kalyan]

Add GLES2 compile time support in OptionsEfl.cmake and PlatformEfl.cmake.

[Kalyan]

Created attachment 180847 [details]
patch

[Thiago Marcos P. Santos]

Comment on attachment 180847 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180847&action=review

> Source/cmake/OptionsEfl.cmake:191
> +        option(ENABLE_GLES2 ON)
> +
> +        if (ENABLE_GLES2)

This if() looks unnecessary since it will never fail. Do we need to set this option()?

[Kalyan]

(In reply to comment #2)
> (From update of attachment 180847 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180847&action=review
> 
> > Source/cmake/OptionsEfl.cmake:191
> > +        option(ENABLE_GLES2 ON)
> > +
> > +        if (ENABLE_GLES2)
> 
> This if() looks unnecessary since it will never fail. Do we need to set this option()?

Yes,in order to enable the option (ENABLE_GLES2), we need to pass --cmakeargs="-DENABLE_GLES2=ON" to the built-webkit` script, otherwise it is never set and the if condition will fail. Atleast that's how I understood the usage of option.

[Kalyan]

Comment on attachment 180847 [details]
patch

removing request for cq till https://bugs.webkit.org/show_bug.cgi?id=105876 is done

[Kalyan]

Created attachment 180968 [details]
patch v2

rebased patch

[WebKit Review Bot]

Comment on attachment 180968 [details]
patch v2

Rejecting attachment 180968 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15593747

[Kenneth Rohde Christiansen]

Comment on attachment 180968 [details]
patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=180968&action=review

> Source/WebCore/ChangeLog:8
> +        [EFL][WebGL] Add compile time support for GLES2.
> +        https://bugs.webkit.org/show_bug.cgi?id=105816
> +
> +        This patch adds build support for GLES2.
> +        GLES2 support can be enabled during compile time by passing -DENABLE_GLES2=ON as
> +        cmake config parameter. GLES2 options is not enabled by default. This patch doesn't

missing reviewer (OOPS!) part

[Kalyan]

Created attachment 180977 [details]
patchv3

[WebKit Review Bot]

Comment on attachment 180977 [details]
patchv3

Clearing flags on attachment: 180977

Committed r138598: <http://trac.webkit.org/changeset/138598>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.