Bug 105876 – [EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Kalyan]

This is to sync the naming conventions of our classes in both EGL and GLX implementations.
In our GLX implementation, class responsible for the same functionality is named as GLXConfigSelector.

[Kalyan]

Created attachment 180961 [details]
patch

[WebKit Review Bot]

Comment on attachment 180961 [details]
patch

Rejecting attachment 180961 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://queues.webkit.org/results/15589687

[Kalyan]

Created attachment 180963 [details]
patchv2

[WebKit Review Bot]

Comment on attachment 180963 [details]
patchv2

Rejecting attachment 180963 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://queues.webkit.org/results/15585773

[Chris Dumez]

Comment on attachment 180963 [details]
patchv2

View in context: https://bugs.webkit.org/attachment.cgi?id=180963&action=review

> Source/WebCore/ChangeLog:1
> +        [EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector.

You're missing the first line of this Changelog.

[Kalyan]

Created attachment 180965 [details]
patch

[Kalyan]

(In reply to comment #5)
> (From update of attachment 180963 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180963&action=review
> 
> > Source/WebCore/ChangeLog:1
> > +        [EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector.
> 
> You're missing the first line of this Changelog.

thanks. Fixed it now.

[WebKit Review Bot]

Comment on attachment 180965 [details]
patch

Clearing flags on attachment: 180965

Committed r138588: <http://trac.webkit.org/changeset/138588>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.