RESOLVED DUPLICATE of bug 118682 119029
Fix HTMLMediaElement so that it doesn't add cues for disabled text tracks 
https://bugs.webkit.org/show_bug.cgi?id=119029
Summary Fix HTMLMediaElement so that it doesn't add cues for disabled text tracks
Ryosuke Niwa
Reported 2013-07-23 17:00:49 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/3aed1192f832e597e96c4f7695b7ab8d3a2339eb This patch reverts the change to TextTrackCue added in https://src.chromium.org/viewvc/blink?revision=153206&view=revision and addresses the actual underlying issue. The real problem is that HTMLMediaElement was allowing cues from disabled tracks to be added to m_cueTree under certain circumstances. This patch adds checks to textTrackAddCues() and textTrackAddCue() to prevent disabled track cues from being added.
Attachments
Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2013-07-24 08:25:24 PDT
(In reply to comment #0) > Consider merging https://chromium.googlesource.com/chromium/blink/+/3aed1192f832e597e96c4f7695b7ab8d3a2339eb > > This patch reverts the change to TextTrackCue added in > https://src.chromium.org/viewvc/blink?revision=153206&view=revision > and addresses the actual underlying issue. The real problem > is that HTMLMediaElement was allowing cues from disabled > tracks to be added to m_cueTree under certain > circumstances. This patch adds checks to textTrackAddCues() > and textTrackAddCue() to prevent disabled track cues from > being added. I merged this change in r152721. You reviewed it ;-) *** This bug has been marked as a duplicate of bug 118682 ***
Note You need to log in before you can comment on or make changes to this bug.