Bug 118682 – HTMLMediaElement should not add cues for disabled text tracks

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Merge blink r153810, https://src.chromium.org/viewvc/blink?view=rev&revision=153810, which extends the changes made in WebKit r152459: http://trac.webkit.org/changeset/152459

[Radar WebKit Bug Importer]

<rdar://problem/14446514>

[Eric Carlson]

Created attachment 206682 [details]
Proposed patch

[Ryosuke Niwa]

Comment on attachment 206682 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206682&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:1490
> -void HTMLMediaElement::textTrackAddCues(TextTrack*, const TextTrackCueList* cues) 
> +void HTMLMediaElement::textTrackAddCues(TextTrack* track, const TextTrackCueList* cues) 

Would it make sense for this function to take PassRefPtr<TextTrack> instead to be safe?

[Eric Carlson]

(In reply to comment #3)
> (From update of attachment 206682 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206682&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:1490
> > -void HTMLMediaElement::textTrackAddCues(TextTrack*, const TextTrackCueList* cues) 
> > +void HTMLMediaElement::textTrackAddCues(TextTrack* track, const TextTrackCueList* cues) 
> 
> Would it make sense for this function to take PassRefPtr<TextTrack> instead to be safe?

Maybe. These functions are part of a larger interface used by a number of other classes so that will be a much bigger change, so I will do it in a separate patch if it does make sense.

[Eric Carlson]

Committed r152721: http://trac.webkit.org/changeset/152721

[Eric Carlson]

*** Bug 119029 has been marked as a duplicate of this bug. ***