Bug 118877 – Bindings generation tests are failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Stephanie Lewis]

http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/8950

Most likely due to http://trac.webkit.org/changeset/152845.

(view as text)
python ./Tools/Scripts/run-bindings-tests
 in dir /Volumes/Data/slave/mountainlion-debug-tests-wk1/build (timeout 1200 secs)
 watching logfiles {}
 argv: ['python', './Tools/Scripts/run-bindings-tests']
 environment:
  Apple_PubSub_Socket_Render=/tmp/launch-XwSvgo/Render
  Apple_Ubiquity_Message=/tmp/launch-FoOMgK/Apple_Ubiquity_Message
  HOME=/Users/buildbot
  LOGNAME=buildbot
  MACOSX_DEPLOYMENT_TARGET=10.8
  OLDPWD=/Users/buildbot
  PATH=/usr/bin:/bin:/usr/sbin:/sbin
  PWD=/Volumes/Data/slave/mountainlion-debug-tests-wk1/build
  SHELL=/bin/bash
  SHLVL=1
  SSH_AUTH_SOCK=/tmp/launch-VDYfHe/Listeners
  TMPDIR=/var/folders/rg/3xbzr5_x083c8kzwn20v95nm0000gn/T/
  USER=buildbot
  VERSIONER_PYTHON_PREFER_32_BIT=no
  VERSIONER_PYTHON_VERSION=2.7
  _=/usr/bin/twistd
  __CF_USER_TEXT_ENCODING=0x1F5:0:0
 closing stdin
 using PTY: False
PASS: (JS) JSTestCallback.cpp
PASS: (JS) JSTestCallback.h
PASS: (JS) JSTestCustomNamedGetter.cpp
PASS: (JS) JSTestCustomNamedGetter.h
PASS: (JS) JSTestActiveDOMObject.cpp
PASS: (JS) JSTestActiveDOMObject.h
PASS: (JS) JSTestEventConstructor.cpp
PASS: (JS) JSTestEventConstructor.h
PASS: (JS) JSTestEventTarget.cpp
PASS: (JS) JSTestEventTarget.h
PASS: (JS) JSTestException.cpp
PASS: (JS) JSTestException.h
PASS: (JS) JSTestImplements.cpp
PASS: (JS) JSTestImplements.h
PASS: (JS) JSTestInterface.cpp
PASS: (JS) JSTestInterface.h
PASS: (JS) JSTestMediaQueryListListener.cpp
PASS: (JS) JSTestMediaQueryListListener.h
PASS: (JS) JSTestNamedConstructor.cpp
PASS: (JS) JSTestNamedConstructor.h
PASS: (JS) JSTestNode.cpp
PASS: (JS) JSTestNode.h
FAIL: (JS) JSTestObj.cpp
--- WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2013-07-17 09:34:07.000000000 -0700
+++ /var/folders/rg/3xbzr5_x083c8kzwn20v95nm0000gn/T/tmpikcKvT/JSTestObj.cpp	2013-07-18 15:51:49.000000000 -0700
@@ -624,7 +624,7 @@
     JSTestObj* castedThis = jsCast<JSTestObj*>(asObject(slotBase));
     UNUSED_PARAM(exec);
     TestObj* impl = static_cast<TestObj*>(castedThis->impl());
-    JSValue result = jsBoolean(impl->fastHasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr));
+    JSValue result = jsBoolean(impl->hasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr));
     return result;
 }
 
@@ -664,7 +664,7 @@
     JSTestObj* castedThis = jsCast<JSTestObj*>(asObject(slotBase));
     UNUSED_PARAM(exec);
     TestObj* impl = static_cast<TestObj*>(castedThis->impl());
-    JSValue result = jsBoolean(impl->fastHasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr));
+    JSValue result = jsBoolean(impl->hasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr));
     return result;
 }
 

PASS: (JS) JSTestObj.h
PASS: (JS) JSTestOverloadedConstructors.cpp
PASS: (JS) JSTestOverloadedConstructors.h
PASS: (JS) JSTestSerializedScriptValueInterface.cpp
PASS: (JS) JSTestSerializedScriptValueInterface.h
PASS: (JS) JSTestSupplemental.cpp
PASS: (JS) JSTestSupplemental.h
PASS: (JS) JSFloat64Array.cpp
PASS: (JS) JSFloat64Array.h
PASS: (JS) JSTestTypedefs.cpp
PASS: (JS) JSTestTypedefs.h
PASS: (ObjC) DOMTestCallback.h
PASS: (ObjC) DOMTestCallback.mm
PASS: (ObjC) DOMTestCallbackInternal.h
PASS: (ObjC) DOMTestCustomNamedGetter.h
PASS: (ObjC) DOMTestCustomNamedGetter.mm
PASS: (ObjC) DOMTestCustomNamedGetterInternal.h
PASS: (ObjC) DOMTestActiveDOMObject.h
PASS: (ObjC) DOMTestActiveDOMObject.mm
PASS: (ObjC) DOMTestActiveDOMObjectInternal.h
PASS: (ObjC) DOMTestEventConstructor.h
PASS: (ObjC) DOMTestEventConstructor.mm
PASS: (ObjC) DOMTestEventConstructorInternal.h
PASS: (ObjC) DOMTestEventTarget.h
PASS: (ObjC) DOMTestEventTarget.mm
PASS: (ObjC) DOMTestEventTargetInternal.h
PASS: (ObjC) DOMTestException.h
PASS: (ObjC) DOMTestException.mm
PASS: (ObjC) DOMTestExceptionInternal.h
PASS: (ObjC) DOMTestImplements.cpp
PASS: (ObjC) DOMTestImplements.h
PASS: (ObjC) DOMTestInterface.h
PASS: (ObjC) DOMTestInterface.mm
PASS: (ObjC) DOMTestInterfaceInternal.h
PASS: (ObjC) DOMTestMediaQueryListListener.h
PASS: (ObjC) DOMTestMediaQueryListListener.mm
PASS: (ObjC) DOMTestMediaQueryListListenerInternal.h
PASS: (ObjC) DOMTestNamedConstructor.h
PASS: (ObjC) DOMTestNamedConstructor.mm
PASS: (ObjC) DOMTestNamedConstructorInternal.h
PASS: (ObjC) DOMTestNode.h
PASS: (ObjC) DOMTestNode.mm
PASS: (ObjC) DOMTestNodeInternal.h
PASS: (ObjC) DOMTestObj.h
FAIL: (ObjC) DOMTestObj.mm
--- WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm	2013-07-17 09:34:07.000000000 -0700
+++ /var/folders/rg/3xbzr5_x083c8kzwn20v95nm0000gn/T/tmppA14TV/DOMTestObj.mm	2013-07-18 15:51:52.000000000 -0700
@@ -303,7 +303,7 @@
 - (BOOL)reflectedBooleanAttr
 {
     WebCore::JSMainThreadNullState state;
-    return IMPL->fastHasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr);
+    return IMPL->hasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr);
 }
 
 - (void)setReflectedBooleanAttr:(BOOL)newReflectedBooleanAttr
@@ -351,7 +351,7 @@
 - (BOOL)reflectedCustomBooleanAttr
 {
     WebCore::JSMainThreadNullState state;
-    return IMPL->fastHasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr);
+    return IMPL->hasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr);
 }
 
 - (void)setReflectedCustomBooleanAttr:(BOOL)newReflectedCustomBooleanAttr

PASS: (ObjC) DOMTestObjInternal.h
PASS: (ObjC) DOMTestOverloadedConstructors.h
PASS: (ObjC) DOMTestOverloadedConstructors.mm
PASS: (ObjC) DOMTestOverloadedConstructorsInternal.h
PASS: (ObjC) DOMTestSerializedScriptValueInterface.h
PASS: (ObjC) DOMTestSerializedScriptValueInterface.mm
PASS: (ObjC) DOMTestSerializedScriptValueInterfaceInternal.h
PASS: (ObjC) DOMTestSupplemental.cpp
PASS: (ObjC) DOMTestSupplemental.h
PASS: (ObjC) DOMFloat64Array.h
PASS: (ObjC) DOMFloat64Array.mm
PASS: (ObjC) DOMFloat64ArrayInternal.h
PASS: (ObjC) DOMTestTypedefs.h
PASS: (ObjC) DOMTestTypedefs.mm
PASS: (ObjC) DOMTestTypedefsInternal.h
PASS: (GObject) WebKitDOMTestCallback.cpp
PASS: (GObject) WebKitDOMTestCallback.h
PASS: (GObject) WebKitDOMTestCallbackPrivate.h
PASS: (GObject) WebKitDOMTestCustomNamedGetter.cpp
PASS: (GObject) WebKitDOMTestCustomNamedGetter.h
PASS: (GObject) WebKitDOMTestCustomNamedGetterPrivate.h
PASS: (GObject) WebKitDOMTestActiveDOMObject.cpp
PASS: (GObject) WebKitDOMTestActiveDOMObject.h
PASS: (GObject) WebKitDOMTestActiveDOMObjectPrivate.h
PASS: (GObject) WebKitDOMTestEventConstructor.cpp
PASS: (GObject) WebKitDOMTestEventConstructor.h
PASS: (GObject) WebKitDOMTestEventConstructorPrivate.h
PASS: (GObject) WebKitDOMTestEventTarget.cpp
PASS: (GObject) WebKitDOMTestEventTarget.h
PASS: (GObject) WebKitDOMTestEventTargetPrivate.h
PASS: (GObject) WebKitDOMTestException.cpp
PASS: (GObject) WebKitDOMTestException.h
PASS: (GObject) WebKitDOMTestExceptionPrivate.h
PASS: (GObject) WebKitDOMTestImplements.cpp
PASS: (GObject) WebKitDOMTestImplements.h
PASS: (GObject) WebKitDOMTestInterface.cpp
PASS: (GObject) WebKitDOMTestInterface.h
PASS: (GObject) WebKitDOMTestInterfacePrivate.h
PASS: (GObject) WebKitDOMTestMediaQueryListListener.cpp
PASS: (GObject) WebKitDOMTestMediaQueryListListener.h
PASS: (GObject) WebKitDOMTestMediaQueryListListenerPrivate.h
PASS: (GObject) WebKitDOMTestNamedConstructor.cpp
PASS: (GObject) WebKitDOMTestNamedConstructor.h
PASS: (GObject) WebKitDOMTestNamedConstructorPrivate.h
PASS: (GObject) WebKitDOMTestNode.cpp
PASS: (GObject) WebKitDOMTestNode.h
PASS: (GObject) WebKitDOMTestNodePrivate.h
FAIL: (GObject) WebKitDOMTestObj.cpp
--- WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp	2013-07-11 08:22:35.000000000 -0700
+++ /var/folders/rg/3xbzr5_x083c8kzwn20v95nm0000gn/T/tmpWAj9J1/WebKitDOMTestObj.cpp	2013-07-18 15:51:55.000000000 -0700
@@ -372,7 +372,7 @@
         break;
     }
     case PROP_REFLECTED_BOOLEAN_ATTR: {
-        g_value_set_boolean(value, coreSelf->fastHasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr));
+        g_value_set_boolean(value, coreSelf->hasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr));
         break;
     }
     case PROP_REFLECTED_URL_ATTR: {
@@ -388,7 +388,7 @@
         break;
     }
     case PROP_REFLECTED_CUSTOM_BOOLEAN_ATTR: {
-        g_value_set_boolean(value, coreSelf->fastHasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr));
+        g_value_set_boolean(value, coreSelf->hasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr));
         break;
     }
     case PROP_REFLECTED_CUSTOM_URL_ATTR: {
@@ -1896,7 +1896,7 @@
     WebCore::JSMainThreadNullState state;
     g_return_val_if_fail(WEBKIT_DOM_IS_TEST_OBJ(self), FALSE);
     WebCore::TestObj* item = WebKit::core(self);
-    gboolean result = item->fastHasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr);
+    gboolean result = item->hasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr);
     return result;
 }
 
@@ -1976,7 +1976,7 @@
     WebCore::JSMainThreadNullState state;
     g_return_val_if_fail(WEBKIT_DOM_IS_TEST_OBJ(self), FALSE);
     WebCore::TestObj* item = WebKit::core(self);
-    gboolean result = item->fastHasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr);
+    gboolean result = item->hasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr);
     return result;
 }
 

PASS: (GObject) WebKitDOMTestObj.h
PASS: (GObject) WebKitDOMTestObjPrivate.h
PASS: (GObject) WebKitDOMTestOverloadedConstructors.cpp
PASS: (GObject) WebKitDOMTestOverloadedConstructors.h
PASS: (GObject) WebKitDOMTestOverloadedConstructorsPrivate.h
PASS: (GObject) WebKitDOMTestSerializedScriptValueInterface.cpp
PASS: (GObject) WebKitDOMTestSerializedScriptValueInterface.h
PASS: (GObject) WebKitDOMTestSerializedScriptValueInterfacePrivate.h
PASS: (GObject) WebKitDOMTestSupplemental.cpp
PASS: (GObject) WebKitDOMTestSupplemental.h
PASS: (GObject) WebKitDOMFloat64Array.cpp
PASS: (GObject) WebKitDOMFloat64Array.h
PASS: (GObject) WebKitDOMFloat64ArrayPrivate.h
PASS: (GObject) WebKitDOMTestTypedefs.cpp
PASS: (GObject) WebKitDOMTestTypedefs.h
PASS: (GObject) WebKitDOMTestTypedefsPrivate.h
PASS: (CPP) WebDOMTestCallback.cpp
PASS: (CPP) WebDOMTestCallback.h
PASS: (CPP) WebDOMTestCustomNamedGetter.cpp
PASS: (CPP) WebDOMTestCustomNamedGetter.h
PASS: (CPP) WebDOMTestActiveDOMObject.cpp
PASS: (CPP) WebDOMTestActiveDOMObject.h
PASS: (CPP) WebDOMTestEventConstructor.cpp
PASS: (CPP) WebDOMTestEventConstructor.h
PASS: (CPP) WebDOMTestEventTarget.cpp
PASS: (CPP) WebDOMTestEventTarget.h
PASS: (CPP) WebDOMTestException.cpp
PASS: (CPP) WebDOMTestException.h
PASS: (CPP) WebDOMTestImplements.cpp
PASS: (CPP) WebDOMTestImplements.h
PASS: (CPP) WebDOMTestInterface.cpp
PASS: (CPP) WebDOMTestInterface.h
PASS: (CPP) WebDOMTestMediaQueryListListener.cpp
PASS: (CPP) WebDOMTestMediaQueryListListener.h
PASS: (CPP) WebDOMTestNamedConstructor.cpp
PASS: (CPP) WebDOMTestNamedConstructor.h
PASS: (CPP) WebDOMTestNode.cpp
PASS: (CPP) WebDOMTestNode.h
FAIL: (CPP) WebDOMTestObj.cpp
--- WebCore/bindings/scripts/test/CPP/WebDOMTestObj.cpp	2013-07-11 08:22:35.000000000 -0700
+++ /var/folders/rg/3xbzr5_x083c8kzwn20v95nm0000gn/T/tmpJ9Zp54/WebDOMTestObj.cpp	2013-07-18 15:51:57.000000000 -0700
@@ -345,7 +345,7 @@
     if (!impl())
         return false;
 
-    return impl()->fastHasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr);
+    return impl()->hasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr);
 }
 
 void WebDOMTestObj::setReflectedBooleanAttr(bool newReflectedBooleanAttr)
@@ -409,7 +409,7 @@
     if (!impl())
         return false;
 
-    return impl()->fastHasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr);
+    return impl()->hasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr);
 }
 
 void WebDOMTestObj::setReflectedCustomBooleanAttr(bool newReflectedCustomBooleanAttr)

PASS: (CPP) WebDOMTestObj.h
PASS: (CPP) WebDOMTestOverloadedConstructors.cpp
PASS: (CPP) WebDOMTestOverloadedConstructors.h
PASS: (CPP) WebDOMTestSerializedScriptValueInterface.cpp
PASS: (CPP) WebDOMTestSerializedScriptValueInterface.h
PASS: (CPP) WebDOMTestSupplemental.cpp
PASS: (CPP) WebDOMTestSupplemental.h
PASS: (CPP) WebDOMFloat64Array.cpp
PASS: (CPP) WebDOMFloat64Array.h
PASS: (CPP) WebDOMTestTypedefs.cpp
PASS: (CPP) WebDOMTestTypedefs.h

Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")
program finished with exit code 255
elapsedTime=12.811412

[Chris Dumez]

Thanks for reporting this. I will take a look.

[Chris Dumez]

Created attachment 207061 [details]
Patch

[Kentaro Hara]

Comment on attachment 207061 [details]
Patch

ok

[Chris Dumez]

Comment on attachment 207061 [details]
Patch

Clearing flags on attachment: 207061

Committed r152886: <http://trac.webkit.org/changeset/152886>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.