We can simplify SVG animated type handling in the JSC bindings generator, especially in these subroutines: - IsSVGAnimatedType() - GetterExpression() Corresponding Blink revisions: https://src.chromium.org/viewvc/blink?revision=154286&view=revision https://src.chromium.org/viewvc/blink?revision=154389&view=revision
Created attachment 206983 [details] Patch
Comment on attachment 206983 [details] Patch ok
Comment on attachment 206983 [details] Patch Clearing flags on attachment: 206983 Committed r152845: <http://trac.webkit.org/changeset/152845>
All reviewed patches have been landed. Closing bug.
Comment on attachment 206983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206983&action=review > Source/WebCore/bindings/scripts/CodeGenerator.pm:575 > + } elsif ($generator->IsSVGAnimatedType($attribute)) { This is wrong. $attribute in this context is a hash, not a string that can be compared. I think this test now always fails, causing us to use "fastGetAttribute" in some cases where it is not safe. This should have been something like: "my $type = $attribute->signature->type; if ($generator->IsSVGAniatedType($type)) { ... do stuff