I've now had two versions of these to play with. I think it would be better if it was checked in
Created attachment 206609 [details] the patch
Attachment 206609 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/ReducedFTL/ReducedFTL.c', u'Tools/ReducedFTL/build.sh']" exit_code: 1 Tools/ReducedFTL/ReducedFTL.c:35: Alphabetical sorting problem. [build/include_order] [4] Tools/ReducedFTL/ReducedFTL.c:40: Alphabetical sorting problem. [build/include_order] [4] Tools/ReducedFTL/ReducedFTL.c:51: Declaration has space between * and variable name in uint8_t* start [whitespace/declaration] [3] Tools/ReducedFTL/ReducedFTL.c:59: Declaration has space between * and variable name in void* opaqueState [whitespace/declaration] [3] Tools/ReducedFTL/ReducedFTL.c:63: Declaration has space between * and variable name in uint8_t* start [whitespace/declaration] [3] Tools/ReducedFTL/ReducedFTL.c:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/ReducedFTL/ReducedFTL.c:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/ReducedFTL/ReducedFTL.c:81: Declaration has space between * and variable name in void* opaqueState [whitespace/declaration] [3] Tools/ReducedFTL/ReducedFTL.c:97: Declaration has space between * and variable name in void* opaque [whitespace/declaration] [3] Tools/ReducedFTL/ReducedFTL.c:119: Place brace on its own line for function definitions. [whitespace/braces] [4] Tools/ReducedFTL/ReducedFTL.c:127: Declaration has space between * and variable name in char* error [whitespace/declaration] [3] Tools/ReducedFTL/ReducedFTL.c:166: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Tools/ReducedFTL/ReducedFTL.c:238: Declaration has space between * and variable name in uint8_t* pc [whitespace/declaration] [3] Tools/ReducedFTL/ReducedFTL.c:239: Declaration has space between * and variable name in uint8_t* end [whitespace/declaration] [3] Total errors found: 14 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 206610 [details] the patch Fix style, hopefully.
Created attachment 206611 [details] the patch Ugh, I keep forgetting proper C style etiquette.
Attachment 206611 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/ReducedFTL/ReducedFTL.c', u'Tools/ReducedFTL/build.sh']" exit_code: 1 Tools/ReducedFTL/ReducedFTL.c:42: Alphabetical sorting problem. [build/include_order] [4] Tools/ReducedFTL/ReducedFTL.c:122: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 206612 [details] the patch
Attachment 206612 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/ReducedFTL/ReducedFTL.c', u'Tools/ReducedFTL/build.sh']" exit_code: 1 Tools/ReducedFTL/ReducedFTL.c:42: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 206616 [details] added more things
Attachment 206616 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/ReducedFTL/ReducedFTL.c', u'Tools/ReducedFTL/build.sh']" exit_code: 1 Tools/ReducedFTL/ReducedFTL.c:45: Alphabetical sorting problem. [build/include_order] [4] Tools/ReducedFTL/ReducedFTL.c:152: Declaration has space between * and variable name in LLVMModuleRef* modules [whitespace/declaration] [3] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 206618 [details] the patch Added options to experiment with contexts.
Attachment 206618 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/ReducedFTL/ReducedFTL.c', u'Tools/ReducedFTL/build.sh']" exit_code: 1 Tools/ReducedFTL/ReducedFTL.c:45: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 206618 [details] the patch rs=me
Landed in http://trac.webkit.org/changeset/152738