Bug 118329 - fourthTier: add option to disable OSR entry in loops
Summary: fourthTier: add option to disable OSR entry in loops
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency tree / graph
 
Reported: 2013-07-02 15:32 PDT by Filip Pizlo
Modified: 2013-07-02 15:55 PDT (History)
7 users (show)

See Also:

Attachments
the patch (6.76 KB, patch)
2013-07-02 15:34 PDT, Filip Pizlo 		mhahnenberg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-07-02 15:32:37 PDT 
Currently if you're using the FTL then OSR entry in loops tries to work, and then fails, and then pretends that it had OSR exited, and the heuristics just go downhill from there.

We should have an option to disable OSR entry in loops both for the benefit of the FTL and because it could be interesting for other testing in the future: like you want to see if OSR entry in loops is the cause of a bug, or something.
Comment 1 Filip Pizlo 2013-07-02 15:34:34 PDT 
Created attachment 205948 [details]
the patch
Comment 2 Mark Hahnenberg 2013-07-02 15:52:56 PDT 
Comment on attachment 205948 [details]
the patch

r=me
Comment 3 Filip Pizlo 2013-07-02 15:55:33 PDT 
Landed in http://trac.webkit.org/changeset/152326