Bug 118250 – iframe constrained by max-width in full screen

• Status: RESOLVED
• Resolution: FIXED
• Component: Frames

[Brad Dougherty]

Overview: 
When a max-width style is applied to an iframe, the constraint persists when an element inside the iframe is put into full screen.

Steps to Reproduce:
1) Go to http://brad.is/reportingbugs/maxwidth/
2) Click on the full screen button

Actual Results:
The element has a max-width of 700px (as defined on the iframe), and the rest of the page contents show in the remaining space.

Expected Results:
The contents of the iframe should fill the entire screen.

Build Date & Platform:
Confirmed that it is happening in Safari 7.0 (9537.46.5) and Safari 6.0.5.
Verified that Firefox 22 has the correct behavior.

[zalan]

Created attachment 206147 [details]
Patch

[Antti Koivisto]

Comment on attachment 206147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206147&action=review

> Source/WebCore/css/fullscreen.css:56
> +    max-width: none !important;
> +    max-height: none !important;
>  }

Should this be done for all :-webkit-full-screen elements instead of just iframe?

[zalan]

Created attachment 206149 [details]
Patch

[Antti Koivisto]

Comment on attachment 206149 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 206149 [details]
Patch

Clearing flags on attachment: 206149

Committed r152424: <http://trac.webkit.org/changeset/152424>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[David Kilzer (:ddkilzer)]

<rdar://problem/14364906>

[Simon Fraser (smfr)]

LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html keeps timing out on the bots. I think it assumes that iframes load synchronously, which is incorrect. Please fix.

[zalan]

(In reply to comment #8)
> LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html keeps timing out on the bots. I think it assumes that iframes load synchronously, which is incorrect. Please fix.

tracking at bug 118842

[zalan]

(In reply to comment #9)
> (In reply to comment #8)
> > LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html keeps timing out on the bots. I think it assumes that iframes load synchronously, which is incorrect. Please fix.
> 
> tracking at bug 118842
and by bug 118842, I meant bug 118820