Bug 118820 – fullscreen/full-screen-iframe-with-max-width-height.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Frames

[Stephanie Lewis]

Flaky on ML, WK1 and WK2.  It looks like it is timing out waiting for an event.

--- /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/fullscreen/full-screen-iframe-with-max-width-height-expected.txt
+++ /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/fullscreen/full-screen-iframe-with-max-width-height-actual.txt
@@ -1,4 +1,4 @@
+CONSOLE MESSAGE: line 14: TypeError: 'null' is not an object (evaluating 'testDiv.webkitRequestFullScreen')
+FAIL: Timed out waiting for notifyDone to be called
 
-EVENT(webkitfullscreenchange) TEST(frame.getBoundingClientRect().right == document.body.getBoundingClientRect().right && frame.getBoundingClientRect().bottom == document.body.getBoundingClientRect().bottom) OK
-END OF TEST

[Stephanie Lewis]

Labelled as flaky in http://trac.webkit.org/changeset/152808

[Sam Weinig]

Seems like the issue is that we are not waiting for iframe to finish loading.  I waiting on the iframes onload will fix this.

[zalan]

Created attachment 206989 [details]
Patch

[Andreas Kling]

Comment on attachment 206989 [details]
Patch

Looks like the correct thing to be doing.

[WebKit Commit Bot]

Comment on attachment 206989 [details]
Patch

Clearing flags on attachment: 206989

Committed r152847: <http://trac.webkit.org/changeset/152847>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.