Bug 118820 - fullscreen/full-screen-iframe-with-max-width-height.html is flaky
Summary: fullscreen/full-screen-iframe-with-max-width-height.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-17 15:57 PDT by Stephanie Lewis
Modified: 2013-07-18 08:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.67 KB, patch)
2013-07-18 07:18 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephanie Lewis 2013-07-17 15:57:26 PDT 
Flaky on ML, WK1 and WK2.  It looks like it is timing out waiting for an event.

--- /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/fullscreen/full-screen-iframe-with-max-width-height-expected.txt
+++ /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/fullscreen/full-screen-iframe-with-max-width-height-actual.txt
@@ -1,4 +1,4 @@
+CONSOLE MESSAGE: line 14: TypeError: 'null' is not an object (evaluating 'testDiv.webkitRequestFullScreen')
+FAIL: Timed out waiting for notifyDone to be called
 
-EVENT(webkitfullscreenchange) TEST(frame.getBoundingClientRect().right == document.body.getBoundingClientRect().right && frame.getBoundingClientRect().bottom == document.body.getBoundingClientRect().bottom) OK
-END OF TEST
Comment 1 Stephanie Lewis 2013-07-17 16:02:10 PDT 
Labelled as flaky in http://trac.webkit.org/changeset/152808
Comment 2 Sam Weinig 2013-07-17 16:14:03 PDT 
Seems like the issue is that we are not waiting for iframe to finish loading.  I waiting on the iframes onload will fix this.
Comment 3 zalan 2013-07-18 07:18:48 PDT 
Created attachment 206989 [details]
Patch
Comment 4 Andreas Kling 2013-07-18 07:25:43 PDT 
Comment on attachment 206989 [details]
Patch

Looks like the correct thing to be doing.
Comment 5 WebKit Commit Bot 2013-07-18 08:42:56 PDT 
Comment on attachment 206989 [details]
Patch

Clearing flags on attachment: 206989

Committed r152847: <http://trac.webkit.org/changeset/152847>
Comment 6 WebKit Commit Bot 2013-07-18 08:42:57 PDT 
All reviewed patches have been landed.  Closing bug.