Bug 118243 – [CSS Blending] Add test suite to validate background blending with different properties

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Mirela]

Add tests to validate background bending with the following properties:
1. Blend a background image and a background color specifying background-position in percentage, such as 50% 50%
2. Blend a background image and a background color specifying background-size in pixels 
3. Blend a background image and a background color specifying background-size in percentage
4. Blend a background image and a background color specifying background-size: cover 
5. Blend a background image and a background color specifying background-size: contain 
6. Blend a background image and a background color specifying background-repeat: no-repeat 
7. Blend a background image and a background color specifying background-clip: padding-box 
8. Blend a background image and a background color specifying background-clip: content-box 
9. Blend a background image and a background color specifying background-origin: border-box 
10. Blend a background image and a background color specifying background-origin: content-box 
11. Blend a background image and a background color specifying background-attachment: fixed

[Mirela]

Created attachment 205810 [details]
Patch

[Mirela]

Created attachment 205906 [details]
Patch

[Build Bot]

Comment on attachment 205906 [details]
Patch

Attachment 205906 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1014527

New failing tests:
media/video-zoom.html

[Build Bot]

Created attachment 205915 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Mirela]

Created attachment 206096 [details]
Patch

[Dirk Schulze]

Comment on attachment 206096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206096&action=review

> LayoutTests/css3/compositing/background-blend-mode-background-attachement-fixed.html:7
> +	background: url('resources/ducky.png'), green;

Do you think it would be possible to use a dataURI of SVG with one color instead? This could make it possible to use ref tests instead of pixel tests.

[Mirela]

(In reply to comment #6)
> (From update of attachment 206096 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206096&action=review
> 
> > LayoutTests/css3/compositing/background-blend-mode-background-attachement-fixed.html:7
> > +	background: url('resources/ducky.png'), green;
> 
> Do you think it would be possible to use a dataURI of SVG with one color instead? This could make it possible to use ref tests instead of pixel tests.

I've tried to use dataURI of SVG but using feBlend in the expected svg file resulted in colour differences between the css blending and the svg feBlend results. I can attach a patch with a simple ref test that I have used.

[Mirela]

Created attachment 208254 [details]
Patch

[Dirk Schulze]

Comment on attachment 208254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208254&action=review

r=me.

> LayoutTests/css3/compositing/background-blend-mode-background-size-cover-expected.html:8
> +	background-size: cover;

this shouldn't be necessary for background-color. After all this is the expected file.

[Mirela]

Created attachment 208260 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 208260 [details]
Patch

Clearing flags on attachment: 208260

Committed r153784: <http://trac.webkit.org/changeset/153784>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.