Bug 118071 – Remove [NoInterfaceObject] from WorkerGlobalScope

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

According to the latest specification, WorkerGlobalScope, SharedWorkerGlobalScope and DedicatedWorkerGlobalScope should not have [NoInterfaceObject]:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#workerglobalscope

They need to be exposed only in specific environments so removing [NoInterfaceObject] is not enough. Extending the [GlobalContext] extended attribute is needed as well.

Corresponding Blink patch:
https://src.chromium.org/viewvc/blink?revision=153070&view=revision

[Chris Dumez]

Created attachment 205587 [details]
WIP Patch

[Chris Dumez]

Created attachment 205596 [details]
Patch

[Kentaro Hara]

Comment on attachment 205596 [details]
Patch

The change in IDL files and Perl scripts looks OK. I didn't check the test result one by one, but LGTM if the result is exactly the same as the Blink's patch.

[Chris Dumez]

(In reply to comment #3)
> (From update of attachment 205596 [details])
> The change in IDL files and Perl scripts looks OK. I didn't check the test result one by one, but LGTM if the result is exactly the same as the Blink's patch.

Yes, the result is the same:
- WorkerGlobalScope is now exposed to JavaScript if the JavaScript global environment is a worker environment.
- DedicatedWorkerGlobalScope is now exposed to JavaScript if the JavaScript global environment is a dedicated worker environment.
- SharedWorkerGlobalScope is now exposed to JavaScript if the JavaScript global environment is a shared worker environment.

[WebKit Commit Bot]

Comment on attachment 205596 [details]
Patch

Clearing flags on attachment: 205596

Committed r152100: <http://trac.webkit.org/changeset/152100>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.