118059 – Rename WorkerContext to WorkerGlobalScope

Bug 118059 - Rename WorkerContext to WorkerGlobalScope

Summary: Rename WorkerContext to WorkerGlobalScope

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Bindings (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Chris Dumez

URL:	http://www.whatwg.org/specs/web-apps/...
Keywords:	BlinkMergeCandidate

Depends on:	118118
Blocks:	118071
	Show dependency tree / graph

Reported:	2013-06-26 07:25 PDT by Chris Dumez
Modified:	2013-06-27 00:19 PDT (History)
CC List:	8 users (show)

See Also:

Attachments
WIP patch (572.66 KB, patch) 2013-06-26 10:27 PDT, Chris Dumez	no flags	Details \| Formatted Diff \| Diff
Patch (600.00 KB, patch) 2013-06-26 11:08 PDT, Chris Dumez	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from APPLE-EWS-3 for win-future (801.77 KB, application/zip) 2013-06-26 16:37 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Chris Dumez 2013-06-26 07:25:17 PDT

According to the latest specification, WorkerContext should be named WorkerGlobalScope:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#workerglobalscope

Until now, the naming did not matter much because the interface was [NoInterfaceObject] and therefore it wasn't exposed. However, in the latest specification, the interface no longer has [NoInterfaceObject] object. We should therefore rename the interface in preparation for the [NoInterfaceObject] IDL extended attribute removal.

Note that DedicatedWorkerContext and SharedWorkerContext should also be renamed accordingly.

Corresponding Blink patch:
https://src.chromium.org/viewvc/blink?revision=153030&view=revision

Comment 1 Chris Dumez 2013-06-26 10:27:14 PDT

Created attachment 205507 [details]
WIP patch

Comment 2 WebKit Commit Bot 2013-06-26 10:31:39 PDT

Attachment 205507 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/DerivedSources.cpp', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/filesystem/WorkerContextFileSystem.cpp', u'Source/WebCore/Modules/filesystem/WorkerContextFileSystem.h', u'Source/WebCore/Modules/filesystem/WorkerContextFileSystem.idl', u'Source/WebCore/Modules/filesystem/WorkerGlobalScopeFileSystem.cpp', u'Source/WebCore/Modules/filesystem/WorkerGlobalScopeFileSystem.h', u'Source/WebCore/Modules/filesystem/WorkerGlobalScopeFileSystem.idl', u'Source/WebCore/Modules/indexeddb/IDBFactory.cpp', u'Source/WebCore/Modules/indexeddb/WorkerContextIndexedDatabase.cpp', u'Source/WebCore/Modules/indexeddb/WorkerContextIndexedDatabase.h', u'Source/WebCore/Modules/indexeddb/WorkerContextIndexedDatabase.idl', u'Source/WebCore/Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp', u'Source/WebCore/Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h', u'Source/WebCore/Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.idl', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Modules/notifications/NotificationCenter.cpp', u'Source/WebCore/Modules/notifications/WorkerContextNotifications.cpp', u'Source/WebCore/Modules/notifications/WorkerContextNotifications.h', u'Source/WebCore/Modules/notifications/WorkerContextNotifications.idl', u'Source/WebCore/Modules/notifications/WorkerGlobalScopeNotifications.cpp', u'Source/WebCore/Modules/notifications/WorkerGlobalScopeNotifications.h', u'Source/WebCore/Modules/notifications/WorkerGlobalScopeNotifications.idl', u'Source/WebCore/Modules/webdatabase/DatabaseContext.cpp', u'Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.cpp', u'Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.h', u'Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.idl', u'Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp', u'Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.h', u'Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.idl', u'Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp', u'Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp', u'Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp', u'Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h', u'Source/WebCore/Target.pri', u'Source/WebCore/UseJSC.cmake', u'Source/WebCore/WebCore.order', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/cpp/WebDOMEventTarget.cpp', u'Source/WebCore/bindings/cpp/WebDOMEventTarget.h', u'Source/WebCore/bindings/generic/ActiveDOMCallback.cpp', u'Source/WebCore/bindings/js/DOMRequestState.h', u'Source/WebCore/bindings/js/JSBindingsAllInOne.cpp', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/bindings/js/JSDOMGlobalObject.cpp', u'Source/WebCore/bindings/js/JSDedicatedWorkerContextCustom.cpp', u'Source/WebCore/bindings/js/JSDedicatedWorkerGlobalScopeCustom.cpp', u'Source/WebCore/bindings/js/JSEventListener.cpp', u'Source/WebCore/bindings/js/JSEventTargetCustom.cpp', u'Source/WebCore/bindings/js/JSWorkerContextBase.cpp', u'Source/WebCore/bindings/js/JSWorkerContextBase.h', u'Source/WebCore/bindings/js/JSWorkerContextCustom.cpp', u'Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp', u'Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h', u'Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp', u'Source/WebCore/bindings/js/ScheduledAction.cpp', u'Source/WebCore/bindings/js/ScheduledAction.h', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.h', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/bindings/js/ScriptState.h', u'Source/WebCore/bindings/js/WorkerScriptController.cpp', u'Source/WebCore/bindings/js/WorkerScriptController.h', u'Source/WebCore/bindings/js/WorkerScriptDebugServer.cpp', u'Source/WebCore/bindings/js/WorkerScriptDebugServer.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bindings/scripts/IDLAttributes.txt', u'Source/WebCore/bindings/scripts/preprocess-idls.pl', u'Source/WebCore/dom/ActiveDOMObject.cpp', u'Source/WebCore/dom/EventTarget.h', u'Source/WebCore/dom/EventTargetFactory.in', u'Source/WebCore/dom/MessagePort.cpp', u'Source/WebCore/dom/ScriptExecutionContext.cpp', u'Source/WebCore/dom/ScriptExecutionContext.h', u'Source/WebCore/inspector/InjectedScriptManager.cpp', u'Source/WebCore/inspector/InjectedScriptManager.h', u'Source/WebCore/inspector/InspectorConsoleInstrumentation.h', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorProfilerAgent.h', u'Source/WebCore/inspector/InspectorRuntimeAgent.h', u'Source/WebCore/inspector/InspectorWorkerAgent.cpp', u'Source/WebCore/inspector/InspectorWorkerAgent.h', u'Source/WebCore/inspector/InstrumentingAgents.cpp', u'Source/WebCore/inspector/InstrumentingAgents.h', u'Source/WebCore/inspector/WorkerDebuggerAgent.cpp', u'Source/WebCore/inspector/WorkerDebuggerAgent.h', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/inspector/WorkerInspectorController.h', u'Source/WebCore/inspector/WorkerRuntimeAgent.cpp', u'Source/WebCore/inspector/WorkerRuntimeAgent.h', u'Source/WebCore/loader/ThreadableLoader.cpp', u'Source/WebCore/loader/WorkerThreadableLoader.cpp', u'Source/WebCore/loader/WorkerThreadableLoader.h', u'Source/WebCore/loader/cache/MemoryCache.cpp', u'Source/WebCore/platform/blackberry/LocalFileSystemBlackBerry.cpp', u'Source/WebCore/platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp', u'Source/WebCore/platform/blackberry/WorkerAsyncFileSystemBlackBerry.h', u'Source/WebCore/platform/blackberry/WorkerAsyncFileWriterBlackBerry.h', u'Source/WebCore/platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.cpp', u'Source/WebCore/platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.h', u'Source/WebCore/platform/blackberry/WorkerPlatformFileWriterClient.cpp', u'Source/WebCore/platform/blackberry/WorkerPlatformFileWriterClient.h', u'Source/WebCore/workers/DedicatedWorkerContext.cpp', u'Source/WebCore/workers/DedicatedWorkerContext.h', u'Source/WebCore/workers/DedicatedWorkerContext.idl', u'Source/WebCore/workers/DedicatedWorkerGlobalScope.cpp', u'Source/WebCore/workers/DedicatedWorkerGlobalScope.h', u'Source/WebCore/workers/DedicatedWorkerGlobalScope.idl', u'Source/WebCore/workers/DedicatedWorkerThread.cpp', u'Source/WebCore/workers/DedicatedWorkerThread.h', u'Source/WebCore/workers/DefaultSharedWorkerRepository.cpp', u'Source/WebCore/workers/SharedWorkerContext.cpp', u'Source/WebCore/workers/SharedWorkerContext.h', u'Source/WebCore/workers/SharedWorkerContext.idl', u'Source/WebCore/workers/SharedWorkerGlobalScope.cpp', u'Source/WebCore/workers/SharedWorkerGlobalScope.h', u'Source/WebCore/workers/SharedWorkerGlobalScope.idl', u'Source/WebCore/workers/SharedWorkerThread.cpp', u'Source/WebCore/workers/SharedWorkerThread.h', u'Source/WebCore/workers/Worker.cpp', u'Source/WebCore/workers/Worker.h', u'Source/WebCore/workers/WorkerContext.cpp', u'Source/WebCore/workers/WorkerContext.h', u'Source/WebCore/workers/WorkerContext.idl', u'Source/WebCore/workers/WorkerContextProxy.h', u'Source/WebCore/workers/WorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerGlobalScope.h', u'Source/WebCore/workers/WorkerGlobalScope.idl', u'Source/WebCore/workers/WorkerGlobalScopeProxy.h', u'Source/WebCore/workers/WorkerLoaderProxy.h', u'Source/WebCore/workers/WorkerMessagingProxy.cpp', u'Source/WebCore/workers/WorkerMessagingProxy.h', u'Source/WebCore/workers/WorkerObjectProxy.h', u'Source/WebCore/workers/WorkerReportingProxy.h', u'Source/WebCore/workers/WorkerRunLoop.cpp', u'Source/WebCore/workers/WorkerRunLoop.h', u'Source/WebCore/workers/WorkerScriptLoader.cpp', u'Source/WebCore/workers/WorkerThread.cpp', u'Source/WebCore/workers/WorkerThread.h', u'Source/WebCore/xml/XMLHttpRequest.cpp', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp']" exit_code: 1
Source/WebCore/workers/WorkerMessagingProxy.cpp:264:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/workers/WorkerMessagingProxy.cpp:271:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/loader/WorkerThreadableLoader.cpp:170:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/loader/WorkerThreadableLoader.cpp:181:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/loader/WorkerThreadableLoader.cpp:193:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/loader/WorkerThreadableLoader.cpp:206:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/loader/WorkerThreadableLoader.cpp:217:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/loader/WorkerThreadableLoader.cpp:239:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/workers/WorkerGlobalScope.h:50:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/workers/WorkerGlobalScopeProxy.h:43:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/workers/DedicatedWorkerGlobalScope.h:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/workers/SharedWorkerGlobalScope.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/Modules/filesystem/WorkerGlobalScopeFileSystem.h:46:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/Modules/filesystem/WorkerGlobalScopeFileSystem.h:47:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp:344:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/workers/DedicatedWorkerGlobalScope.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 17 in 123 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Chris Dumez 2013-06-26 11:08:49 PDT

Created attachment 205508 [details]
Patch

Comment 4 WebKit Commit Bot 2013-06-26 11:13:10 PDT

Attachment 205508 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.cpp', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/filesystem/WorkerContextFileSystem.cpp', u'Source/WebCore/Modules/filesystem/WorkerContextFileSystem.h', u'Source/WebCore/Modules/filesystem/WorkerContextFileSystem.idl', u'Source/WebCore/Modules/filesystem/WorkerGlobalScopeFileSystem.cpp', u'Source/WebCore/Modules/filesystem/WorkerGlobalScopeFileSystem.h', u'Source/WebCore/Modules/filesystem/WorkerGlobalScopeFileSystem.idl', u'Source/WebCore/Modules/indexeddb/IDBFactory.cpp', u'Source/WebCore/Modules/indexeddb/WorkerContextIndexedDatabase.cpp', u'Source/WebCore/Modules/indexeddb/WorkerContextIndexedDatabase.h', u'Source/WebCore/Modules/indexeddb/WorkerContextIndexedDatabase.idl', u'Source/WebCore/Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp', u'Source/WebCore/Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h', u'Source/WebCore/Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.idl', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Modules/notifications/NotificationCenter.cpp', u'Source/WebCore/Modules/notifications/WorkerContextNotifications.cpp', u'Source/WebCore/Modules/notifications/WorkerContextNotifications.h', u'Source/WebCore/Modules/notifications/WorkerContextNotifications.idl', u'Source/WebCore/Modules/notifications/WorkerGlobalScopeNotifications.cpp', u'Source/WebCore/Modules/notifications/WorkerGlobalScopeNotifications.h', u'Source/WebCore/Modules/notifications/WorkerGlobalScopeNotifications.idl', u'Source/WebCore/Modules/webdatabase/DatabaseContext.cpp', u'Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.cpp', u'Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.h', u'Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.idl', u'Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp', u'Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.h', u'Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.idl', u'Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp', u'Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp', u'Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp', u'Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h', u'Source/WebCore/Target.pri', u'Source/WebCore/UseJSC.cmake', u'Source/WebCore/WebCore.order', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/cpp/WebDOMEventTarget.cpp', u'Source/WebCore/bindings/cpp/WebDOMEventTarget.h', u'Source/WebCore/bindings/generic/ActiveDOMCallback.cpp', u'Source/WebCore/bindings/js/DOMRequestState.h', u'Source/WebCore/bindings/js/JSBindingsAllInOne.cpp', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/bindings/js/JSDOMGlobalObject.cpp', u'Source/WebCore/bindings/js/JSDedicatedWorkerContextCustom.cpp', u'Source/WebCore/bindings/js/JSDedicatedWorkerGlobalScopeCustom.cpp', u'Source/WebCore/bindings/js/JSEventListener.cpp', u'Source/WebCore/bindings/js/JSEventTargetCustom.cpp', u'Source/WebCore/bindings/js/JSWorkerContextBase.cpp', u'Source/WebCore/bindings/js/JSWorkerContextBase.h', u'Source/WebCore/bindings/js/JSWorkerContextCustom.cpp', u'Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp', u'Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h', u'Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp', u'Source/WebCore/bindings/js/ScheduledAction.cpp', u'Source/WebCore/bindings/js/ScheduledAction.h', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.h', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/bindings/js/ScriptState.h', u'Source/WebCore/bindings/js/WorkerScriptController.cpp', u'Source/WebCore/bindings/js/WorkerScriptController.h', u'Source/WebCore/bindings/js/WorkerScriptDebugServer.cpp', u'Source/WebCore/bindings/js/WorkerScriptDebugServer.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bindings/scripts/IDLAttributes.txt', u'Source/WebCore/bindings/scripts/preprocess-idls.pl', u'Source/WebCore/dom/ActiveDOMObject.cpp', u'Source/WebCore/dom/EventTarget.h', u'Source/WebCore/dom/EventTargetFactory.in', u'Source/WebCore/dom/MessagePort.cpp', u'Source/WebCore/dom/ScriptExecutionContext.cpp', u'Source/WebCore/dom/ScriptExecutionContext.h', u'Source/WebCore/inspector/InjectedScriptManager.cpp', u'Source/WebCore/inspector/InjectedScriptManager.h', u'Source/WebCore/inspector/InspectorConsoleInstrumentation.h', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorProfilerAgent.h', u'Source/WebCore/inspector/InspectorRuntimeAgent.h', u'Source/WebCore/inspector/InspectorWorkerAgent.cpp', u'Source/WebCore/inspector/InspectorWorkerAgent.h', u'Source/WebCore/inspector/InstrumentingAgents.cpp', u'Source/WebCore/inspector/InstrumentingAgents.h', u'Source/WebCore/inspector/WorkerDebuggerAgent.cpp', u'Source/WebCore/inspector/WorkerDebuggerAgent.h', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/inspector/WorkerInspectorController.h', u'Source/WebCore/inspector/WorkerRuntimeAgent.cpp', u'Source/WebCore/inspector/WorkerRuntimeAgent.h', u'Source/WebCore/loader/ThreadableLoader.cpp', u'Source/WebCore/loader/WorkerThreadableLoader.cpp', u'Source/WebCore/loader/WorkerThreadableLoader.h', u'Source/WebCore/loader/cache/MemoryCache.cpp', u'Source/WebCore/platform/blackberry/LocalFileSystemBlackBerry.cpp', u'Source/WebCore/platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp', u'Source/WebCore/platform/blackberry/WorkerAsyncFileSystemBlackBerry.h', u'Source/WebCore/platform/blackberry/WorkerAsyncFileWriterBlackBerry.h', u'Source/WebCore/platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.cpp', u'Source/WebCore/platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.h', u'Source/WebCore/platform/blackberry/WorkerPlatformFileWriterClient.cpp', u'Source/WebCore/platform/blackberry/WorkerPlatformFileWriterClient.h', u'Source/WebCore/workers/DedicatedWorkerContext.cpp', u'Source/WebCore/workers/DedicatedWorkerContext.h', u'Source/WebCore/workers/DedicatedWorkerContext.idl', u'Source/WebCore/workers/DedicatedWorkerGlobalScope.cpp', u'Source/WebCore/workers/DedicatedWorkerGlobalScope.h', u'Source/WebCore/workers/DedicatedWorkerGlobalScope.idl', u'Source/WebCore/workers/DedicatedWorkerThread.cpp', u'Source/WebCore/workers/DedicatedWorkerThread.h', u'Source/WebCore/workers/DefaultSharedWorkerRepository.cpp', u'Source/WebCore/workers/SharedWorkerContext.cpp', u'Source/WebCore/workers/SharedWorkerContext.h', u'Source/WebCore/workers/SharedWorkerContext.idl', u'Source/WebCore/workers/SharedWorkerGlobalScope.cpp', u'Source/WebCore/workers/SharedWorkerGlobalScope.h', u'Source/WebCore/workers/SharedWorkerGlobalScope.idl', u'Source/WebCore/workers/SharedWorkerThread.cpp', u'Source/WebCore/workers/SharedWorkerThread.h', u'Source/WebCore/workers/Worker.cpp', u'Source/WebCore/workers/Worker.h', u'Source/WebCore/workers/WorkerContext.cpp', u'Source/WebCore/workers/WorkerContext.h', u'Source/WebCore/workers/WorkerContext.idl', u'Source/WebCore/workers/WorkerContextProxy.h', u'Source/WebCore/workers/WorkerGlobalScope.cpp', u'Source/WebCore/workers/WorkerGlobalScope.h', u'Source/WebCore/workers/WorkerGlobalScope.idl', u'Source/WebCore/workers/WorkerGlobalScopeProxy.h', u'Source/WebCore/workers/WorkerLoaderProxy.h', u'Source/WebCore/workers/WorkerMessagingProxy.cpp', u'Source/WebCore/workers/WorkerMessagingProxy.h', u'Source/WebCore/workers/WorkerObjectProxy.h', u'Source/WebCore/workers/WorkerReportingProxy.h', u'Source/WebCore/workers/WorkerRunLoop.cpp', u'Source/WebCore/workers/WorkerRunLoop.h', u'Source/WebCore/workers/WorkerScriptLoader.cpp', u'Source/WebCore/workers/WorkerThread.cpp', u'Source/WebCore/workers/WorkerThread.h', u'Source/WebCore/xml/XMLHttpRequest.cpp', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp']" exit_code: 1
Source/WebCore/workers/WorkerMessagingProxy.cpp:264:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/workers/WorkerMessagingProxy.cpp:271:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/loader/WorkerThreadableLoader.cpp:170:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/loader/WorkerThreadableLoader.cpp:181:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/loader/WorkerThreadableLoader.cpp:193:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/loader/WorkerThreadableLoader.cpp:206:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/loader/WorkerThreadableLoader.cpp:217:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/loader/WorkerThreadableLoader.cpp:239:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/workers/WorkerGlobalScope.h:50:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/workers/WorkerGlobalScopeProxy.h:43:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/workers/DedicatedWorkerGlobalScope.h:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/workers/SharedWorkerGlobalScope.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/Modules/filesystem/WorkerGlobalScopeFileSystem.h:46:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/Modules/filesystem/WorkerGlobalScopeFileSystem.h:47:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 15 in 125 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Build Bot 2013-06-26 16:37:50 PDT

Comment on attachment 205508 [details]
Patch

Attachment 205508 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/877284

New failing tests:
fast/media/mq-transform-03.html
fast/forms/search-event-delay.html
fast/media/mq-transform-02.html
platform/win/accessibility/multiple-select-element-role.html

Comment 6 Build Bot 2013-06-26 16:37:52 PDT

Created attachment 205538 [details]
Archive of layout-test-results from APPLE-EWS-3 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-3  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

Comment 7 Kentaro Hara 2013-06-26 16:47:05 PDT

Comment on attachment 205508 [details]
Patch

Looks good.

Comment 8 Chris Dumez 2013-06-26 22:58:35 PDT

Comment on attachment 205508 [details]
Patch

Bot failure seems unrelated.

Comment 9 WebKit Commit Bot 2013-06-26 23:22:31 PDT

Comment on attachment 205508 [details]
Patch

Clearing flags on attachment: 205508

Committed r152080: <http://trac.webkit.org/changeset/152080>

Comment 10 WebKit Commit Bot 2013-06-26 23:22:35 PDT

All reviewed patches have been landed.  Closing bug.