Bug 118000 – Flex boxes (both old and new) don't handle max-height images correctly

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

Flex boxes (both old and new) don't handle max-height images correctly. They need to pick up the percentage height descendant code that the blocks base class uses, and that code also needs to be improved to dirty pref widths when percentage heights are involved.

[Dave Hyatt]

Created attachment 205419 [details]
Patch

[Build Bot]

Comment on attachment 205419 [details]
Patch

Attachment 205419 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/987059

New failing tests:
tables/mozilla_expected_failures/bugs/bug85016.html

[Build Bot]

Created attachment 205426 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 205419 [details]
Patch

Attachment 205419 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/986053

New failing tests:
tables/mozilla_expected_failures/bugs/bug85016.html

[Build Bot]

Created attachment 205437 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 205419 [details]
Patch

Attachment 205419 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/967190

New failing tests:
fast/frames/seamless/seamless-nested-crash.html

[Build Bot]

Created attachment 205449 [details]
Archive of layout-test-results from APPLE-EWS-6 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-6  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

[Dave Hyatt]

Landed in r151997.

[Csaba Osztrogonác]

(In reply to comment #8)
> Landed in r151997.

It broke the !ENABLE(SVG) builds:
/ramdisk/qt-linux-release-minimal/build/Source/WebCore/rendering/RenderBlock.cpp: In member function ‘void WebCore::RenderBlock::dirtyForLayoutFromPercentageHeightDescendants()’:
/ramdisk/qt-linux-release-minimal/build/Source/WebCore/rendering/RenderBlock.cpp:2542:22: error: ‘class WebCore::RenderBox’ has no member named ‘hasAspectRatio’


The problem is that RenderObject::hasAspectRatio() is inside !ENABLE(SVG)
ifdef guard. It shouldn't be used outside !ENABLE(SVG) guard.

Could you fix it, please?

[Gábor Ábrahám]

The css3/flexbox/image-percent-max-height.html ref html failed on Qt, Efl, and Gtk bots. Could you check it please?