Bug 117853 – WebGL files not included in Windows build (take 2)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Alex Christensen]

https://bugs.webkit.org/show_bug.cgi?id=117809 was rolled out in r151770 because it broke the Windows build after all.  This patch is trying to do the same thing, that is, include the WebGL source files in the Windows build.  This time I copy the necessary headers and fix a syntax error in LoopBlinnShader.cpp that has been broken and unused for a while.

[Alex Christensen]

Created attachment 205129 [details]
Patch

[Build Bot]

Comment on attachment 205129 [details]
Patch

Attachment 205129 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/884381

[Brent Fulgham]

Comment on attachment 205129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205129&action=review

Looks good.  I'm going to try building it locally.

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:148
> +    <ClCompile Include="$(ConfigurationBuildDir)\obj32\WebCore\DerivedSources\JSEXTDrawBuffers.cpp">

I hate how Visual Studio creates all this solution/project file churn.

[Alex Christensen]

Created attachment 205195 [details]
Patch

[Brent Fulgham]

Comment on attachment 205195 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205195&action=review

> Source/WebCore/WebCore.vcxproj/WebCorePreBuild.cmd:7
> +xcopy %WEBKIT_SOURCE%\ThirdParty\ANGLE\include %CONFIGURATIONBUILDDIR%\include /s

You should put both path arguments to xcopy in quotes so that the build doesn't break if someone uses a path with spaces in it.

[Alex Christensen]

Created attachment 205199 [details]
Patch

[Alex Christensen]

Created attachment 205202 [details]
Patch

[Build Bot]

Comment on attachment 205202 [details]
Patch

Attachment 205202 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/921887

[kov's GTK+ EWS bot]

Comment on attachment 205202 [details]
Patch

Attachment 205202 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/956414

[Early Warning System Bot]

Comment on attachment 205202 [details]
Patch

Attachment 205202 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/956415

[Early Warning System Bot]

Comment on attachment 205202 [details]
Patch

Attachment 205202 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/961144

[EFL EWS Bot]

Comment on attachment 205202 [details]
Patch

Attachment 205202 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/937703

[Build Bot]

Comment on attachment 205202 [details]
Patch

Attachment 205202 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/960184

[Alex Christensen]

Created attachment 205209 [details]
Patch

[Brent Fulgham]

Comment on attachment 205209 [details]
Patch

Looks good!

[Alex Christensen]

I'm going to wait until the Windows bot turns green, then I'll cq+ it

[WebKit Commit Bot]

Comment on attachment 205209 [details]
Patch

Clearing flags on attachment: 205209

Committed r151854: <http://trac.webkit.org/changeset/151854>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.