Bug 117809 - WebGL files not included in Windows build
Summary: WebGL files not included in Windows build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P3 Minor
Assignee: Nobody
URL:
Keywords:
Depends on: 117821
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-19 15:36 PDT by Alex Christensen
Modified: 2013-08-20 09:04 PDT (History)
2 users (show)

See Also:


Attachments
Patch (25.93 KB, patch)
2013-06-19 15:40 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-06-19 15:36:37 PDT
There are many WebGL source files in these directories that are protected by #if ENABLE(WEBGL) or #if USE(3D_GRAPHICS), so adding them will not break any existing build systems.

Source/WebCore/platform/graphics
Source/WebCore/platform/graphics/gpu
Source/WebCore/platform/graphics/opengl
Source/WebCore/html/canvas
Comment 1 Alex Christensen 2013-06-19 15:40:55 PDT
Created attachment 205034 [details]
Patch
Comment 2 Brent Fulgham 2013-06-19 21:41:34 PDT
Comment on attachment 205034 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-06-19 22:06:25 PDT
Comment on attachment 205034 [details]
Patch

Clearing flags on attachment: 205034

Committed r151769: <http://trac.webkit.org/changeset/151769>
Comment 4 WebKit Commit Bot 2013-06-19 22:06:27 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2013-06-19 22:36:27 PDT
Re-opened since this is blocked by bug 117821
Comment 6 Brent Fulgham 2013-06-19 22:46:35 PDT
(In reply to comment #0)
> There are many WebGL source files in these directories that are protected by #if ENABLE(WEBGL) or #if USE(3D_GRAPHICS), so adding them will not break any existing build systems.
> 
> Source/WebCore/platform/graphics
> Source/WebCore/platform/graphics/gpu
> Source/WebCore/platform/graphics/opengl
> Source/WebCore/html/canvas

Our Apple Windows build does enable WebGL, or perhaps turning on accelerated 3D turns it on.  Either way, this patch broke the build so I backed it out.

The main issue seems to be a lack of GL/glext.h in the Microsoft OpenGL implementation.

We might be able to include the Mesa version of the file in WebKitLIbraris/win/include or similar to get things to compile.
Comment 7 Alex Christensen 2013-08-20 09:04:48 PDT
r151769