Bug 117651 – <meter> element text value exposed as AXTitle; should be exposing AXValueDescription

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[James Craig]

Created attachment 204731 [details]
test case

<meter> element text value exposed as AXTitle; should be exposing AXValueDescription

related to bug 109023 and bug 117650

[James Craig]

<rdar://problem/14159520>

[Samuel White]

Created attachment 210794 [details]
Patch for feedback/test results.

Submitting for feedback and platform test failure results, no review needed.

I'm not sure if we should handle this change at the platform level as implemented, or if we should move to the axObject level so other platforms inherit this behavior. Given the close relationship between the APIs I tend to think the latter is the correct solution. Thoughts? Thanks.

[chris fleizach]

Comment on attachment 210794 [details]
Patch for feedback/test results.

View in context: https://bugs.webkit.org/attachment.cgi?id=210794&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2251
> +        RenderObject* renderer = m_object->renderer();

i think we should add a isMeterElement() method in AccessibilityObject, so we don't have to check the renderer() object in the platform
that will also allow us to remove the ENALBE(METER_ELEMENT) check here. that can just be moved inside isMeterElement()

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2615
> +        RenderObject* renderer = m_object->renderer();

ditto

> LayoutTests/accessibility/meter-element.html:28
> +        debug(meter.valueDescription);

we should probably append "AXValueDescription" in the logging here so that we know what's being output in the expected results

[Samuel White]

Created attachment 211071 [details]
Patch.

Updated test output and added isMeter method as requested. Thanks for taking a look Chris.

[Build Bot]

Comment on attachment 211071 [details]
Patch.

Attachment 211071 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1732470

New failing tests:
platform/mac/accessibility/aria-valuetext.html

[Build Bot]

Created attachment 211075 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Samuel White]

Created attachment 211082 [details]
Patch.

Updated WebKit 2 output to fix failures.

[Build Bot]

Comment on attachment 211082 [details]
Patch.

Attachment 211082 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1733453

New failing tests:
platform/mac/accessibility/aria-valuetext.html

[Build Bot]

Created attachment 211093 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Build Bot]

Comment on attachment 211082 [details]
Patch.

Attachment 211082 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1737277

New failing tests:
platform/mac/accessibility/aria-valuetext.html

[Build Bot]

Created attachment 211103 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Build Bot]

Comment on attachment 211082 [details]
Patch.

Attachment 211082 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1728517

New failing tests:
platform/mac/accessibility/aria-valuetext.html

[Build Bot]

Created attachment 211109 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Samuel White]

Created attachment 211149 [details]
Patch.

Missed one layout test on the last pass that needed updating. Should be good now.

[Samuel White]

Created attachment 211155 [details]
Patch.

Deleted a tab character that snuck in somehow.

[Mario Sanchez Prada]

Comment on attachment 211155 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=211155&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:545
> +    return false;

We will get a warning (that might be treated as an error) in some platforms if you don't put this return inside an #else branch, due to it being an unreachable statement when METER_ELEMENT is enabled.

[Samuel White]

Created attachment 211246 [details]
Patch.

[Samuel White]

(In reply to comment #16)
> (From update of attachment 211155 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211155&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:545
> > +    return false;
> 
> We will get a warning (that might be treated as an error) in some platforms if you don't put this return inside an #else branch, due to it being an unreachable statement when METER_ELEMENT is enabled.

Thanks for the tip.

[Mario Sanchez Prada]

Comment on attachment 211246 [details]
Patch.

Looks good to me.

[WebKit Commit Bot]

Comment on attachment 211246 [details]
Patch.

Clearing flags on attachment: 211246

Committed r155603: <http://trac.webkit.org/changeset/155603>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.