Bug 117650 - <meter> element AXValue is listed as a writable value
Summary: <meter> element AXValue is listed as a writable value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 109023
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-14 12:45 PDT by James Craig
Modified: 2013-09-12 15:40 PDT (History)
8 users (show)

See Also:

Attachments
test case (369 bytes, text/html)
2013-06-14 12:45 PDT, James Craig 		no flags Details
Patch. (3.82 KB, patch)
2013-09-12 11:18 PDT, Samuel White 		no flags Details | Formatted Diff | Diff
Patch. (3.75 KB, patch)
2013-09-12 13:47 PDT, Samuel White 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2013-06-14 12:45:15 PDT 
<meter> element AXValue is listed as a writable value

related to bug 109023
Comment 1 James Craig 2013-06-14 12:45:49 PDT 
Created attachment 204730 [details]
test case
Comment 2 James Craig 2013-06-14 12:46:34 PDT 
<rdar://problem/14159536>
Comment 3 Samuel White 2013-09-12 11:18:49 PDT 
Created attachment 211450 [details]
Patch.

Changed writability of meter element AXValue to false.
Comment 4 chris fleizach 2013-09-12 11:42:40 PDT 
Comment on attachment 211450 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=211450&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2679
> +    if (!isMeter() && (isProgressIndicator() || isSlider()))

this would *might* still allow a meter element to be writable isReadOnly returned false

You might want to do

if (isMeter())
return false;

which will keep the logic simple
Comment 5 Samuel White 2013-09-12 13:47:33 PDT 
Created attachment 211468 [details]
Patch.

I didn't worry about placing the isMeter check before the aria-readonly logic because those checks shouldn't apply given the role. But, I see your point about avoiding a potential edge case. Thanks for the help.
Comment 6 WebKit Commit Bot 2013-09-12 15:40:46 PDT 
Comment on attachment 211468 [details]
Patch.

Clearing flags on attachment: 211468

Committed r155653: <http://trac.webkit.org/changeset/155653>
Comment 7 WebKit Commit Bot 2013-09-12 15:40:49 PDT 
All reviewed patches have been landed.  Closing bug.