Bug 117635 - [Qt] Remove Qt specific QTKIT flagged code.
Summary: [Qt] Remove Qt specific QTKIT flagged code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Brüning
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-14 04:01 PDT by Michael Brüning
Modified: 2013-06-17 08:16 PDT (History)
10 users (show)

See Also:


Attachments
Patch (38.07 KB, patch)
2013-06-14 04:12 PDT, Michael Brüning
no flags Details | Formatted Diff | Diff
Patch (52.93 KB, patch)
2013-06-17 06:26 PDT, Michael Brüning
no flags Details | Formatted Diff | Diff
Patch (53.04 KB, patch)
2013-06-17 06:42 PDT, Michael Brüning
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Brüning 2013-06-14 04:01:55 PDT
[Qt] Remove Qt specific QTKIT flagged code.
Comment 1 Michael Brüning 2013-06-14 04:12:21 PDT
Created attachment 204699 [details]
Patch
Comment 2 Eric Carlson 2013-06-14 07:44:29 PDT
Should the QTKit-related code protected by "USE(GSTREAMER)" elsewhere (eg. WebVideoFullscreenController.mm) also be removed, or it used by other ports?
Comment 3 Simon Hausmann 2013-06-14 14:43:31 PDT
It seems to originate from bug #52280 and appears to be unrelated to this bug. That said, from the Qt side we are not using gstreamer on Mac OS X.
Comment 4 Michael Brüning 2013-06-17 05:11:22 PDT
It seems that WebVideoFullscreenController.mm is in fact only used by the Mac port, at least telling from the build files.

Philippe, are you aware if this is used by any other port?
Comment 5 Philippe Normand 2013-06-17 05:38:08 PDT
Some years ago I added some GStreamer support to the mac wk1 port but nowadays this is unmaintained. Feel free to remove it.

Perhaps one day somebody will step up to add GStreamer support to the mac wk2 port :)
Comment 6 Michael Brüning 2013-06-17 06:26:58 PDT
Created attachment 204816 [details]
Patch
Comment 7 Michael Brüning 2013-06-17 06:29:44 PDT
I overlooked a couple of Qt-specific files that were not used anymore due to this change. The new patch removes those.

Eric, I'll file a new bug for the GStreamer code in the Mac port and cc you, I think it's nicer to keep theses things separate in case someone wants to enable GStreamer support on Mac again for some reason...
Comment 8 Early Warning System Bot 2013-06-17 06:35:48 PDT
Comment on attachment 204816 [details]
Patch

Attachment 204816 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/918054
Comment 9 Michael Brüning 2013-06-17 06:42:49 PDT
Created attachment 204818 [details]
Patch
Comment 10 Simon Hausmann 2013-06-17 07:24:16 PDT
Comment on attachment 204818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204818&action=review

> Source/WebKit/mac/WebView/WebView.mm:1528
> +#if PLATFORM(MAC)

Funny to see #if PLATFORM(QT) in this file :)
Comment 11 Michael Brüning 2013-06-17 07:35:45 PDT
Committed r151642: <http://trac.webkit.org/changeset/151642>
Comment 12 Eric Carlson 2013-06-17 08:16:07 PDT
(In reply to comment #7)
> I overlooked a couple of Qt-specific files that were not used anymore due to this change. The new patch removes those.
> 
> Eric, I'll file a new bug for the GStreamer code in the Mac port and cc you, I think it's nicer to keep theses things separate in case someone wants to enable GStreamer support on Mac again for some reason...

I agree that keeping these separate is a good idea. Thanks for looking into this!