Support for GStreamer platformMedia is missing in WebView/WebVideoFullscreenController.mm
Created attachment 78663 [details] proposed patch
Attachment 78663 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit/mac/ChangeLog', u'WebKit/mac/WebVie..." exit_code: 1 WebKit/mac/WebView/WebVideoFullscreenController.mm:112: Line contains tab character. [whitespace/tab] [5] WebKit/mac/WebView/WebVideoFullscreenController.mm:113: Line contains tab character. [whitespace/tab] [5] WebKit/mac/WebView/WebVideoFullscreenController.mm:114: Line contains tab character. [whitespace/tab] [5] WebKit/mac/WebView/WebVideoFullscreenController.mm:150: Line contains tab character. [whitespace/tab] [5] WebKit/mac/WebView/WebVideoFullscreenController.mm:151: Line contains tab character. [whitespace/tab] [5] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 78664 [details] proposed patch
Eric, when you get time can you please look at this patch? Thanks!
Comment on attachment 78664 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=78664&action=review Seems we could use functions to abstract away some of this, no? > WebKit/mac/WebView/WebVideoFullscreenController.mm:117 > + [window setHasShadow:YES]; // This is nicer with a shadow. > + [window setLevel:NSPopUpMenuWindowLevel-1]; Seems this is shared with the QT path, no?
Created attachment 84196 [details] proposed patch
Attachment 84196 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/mac/WebView/WebVideoFullscreenController.mm:108: Line contains tab character. [whitespace/tab] [5] Source/WebKit/mac/WebView/WebVideoFullscreenController.mm:109: Line contains tab character. [whitespace/tab] [5] Source/WebKit/mac/WebView/WebVideoFullscreenController.mm:110: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 84198 [details] proposed patch
Thanks Eric, both of you :) Committed r80136: <http://trac.webkit.org/changeset/80136>