Bug 52280 - [GStreamer] support in mac video fullscreen controller
Summary: [GStreamer] support in mac video fullscreen controller
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-12 01:34 PST by Philippe Normand
Modified: 2011-03-02 08:58 PST (History)
2 users (show)

See Also:


Attachments
proposed patch (4.35 KB, patch)
2011-01-12 01:36 PST, Philippe Normand
no flags Details | Formatted Diff | Diff
proposed patch (4.52 KB, patch)
2011-01-12 01:47 PST, Philippe Normand
eric: review-
Details | Formatted Diff | Diff
proposed patch (6.32 KB, patch)
2011-03-01 00:23 PST, Philippe Normand
no flags Details | Formatted Diff | Diff
proposed patch (6.34 KB, patch)
2011-03-01 00:29 PST, Philippe Normand
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-01-12 01:34:24 PST
Support for GStreamer platformMedia is missing in WebView/WebVideoFullscreenController.mm
Comment 1 Philippe Normand 2011-01-12 01:36:26 PST
Created attachment 78663 [details]
proposed patch
Comment 2 WebKit Review Bot 2011-01-12 01:39:30 PST
Attachment 78663 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit/mac/ChangeLog', u'WebKit/mac/WebVie..." exit_code: 1

WebKit/mac/WebView/WebVideoFullscreenController.mm:112:  Line contains tab character.  [whitespace/tab] [5]
WebKit/mac/WebView/WebVideoFullscreenController.mm:113:  Line contains tab character.  [whitespace/tab] [5]
WebKit/mac/WebView/WebVideoFullscreenController.mm:114:  Line contains tab character.  [whitespace/tab] [5]
WebKit/mac/WebView/WebVideoFullscreenController.mm:150:  Line contains tab character.  [whitespace/tab] [5]
WebKit/mac/WebView/WebVideoFullscreenController.mm:151:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 5 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Philippe Normand 2011-01-12 01:47:45 PST
Created attachment 78664 [details]
proposed patch
Comment 4 Philippe Normand 2011-02-18 07:01:46 PST
Eric, when you get time can you please look at this patch? Thanks!
Comment 5 Eric Seidel (no email) 2011-02-18 12:32:01 PST
Comment on attachment 78664 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78664&action=review

Seems we could use functions to abstract away some of this, no?

> WebKit/mac/WebView/WebVideoFullscreenController.mm:117
> +    [window setHasShadow:YES]; // This is nicer with a shadow.
> +    [window setLevel:NSPopUpMenuWindowLevel-1];

Seems this is shared with the QT path, no?
Comment 6 Philippe Normand 2011-03-01 00:23:04 PST
Created attachment 84196 [details]
proposed patch
Comment 7 WebKit Review Bot 2011-03-01 00:26:28 PST
Attachment 84196 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1

Source/WebKit/mac/WebView/WebVideoFullscreenController.mm:108:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit/mac/WebView/WebVideoFullscreenController.mm:109:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit/mac/WebView/WebVideoFullscreenController.mm:110:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Philippe Normand 2011-03-01 00:29:04 PST
Created attachment 84198 [details]
proposed patch
Comment 9 Philippe Normand 2011-03-02 08:58:11 PST
Thanks Eric, both of you :)

Committed r80136: <http://trac.webkit.org/changeset/80136>