Bug 117588 - [CSS Blending] SVG background images don't blend with any other layer
Summary: [CSS Blending] SVG background images don't blend with any other layer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 108546
  Show dependency tree / graph
 
Reported: 2013-06-13 05:24 PDT by Mirela
Modified: 2013-06-13 11:25 PDT (History)
7 users (show)

See Also:

Attachments
Test case (2.16 KB, application/zip)
2013-06-13 05:38 PDT, Mirela 		no flags Details
Patch for review (317.96 KB, patch)
2013-06-13 06:05 PDT, Mihai Tica 		no flags Details | Formatted Diff | Diff
Patch (317.67 KB, patch)
2013-06-13 09:53 PDT, Mihai Tica 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mirela 2013-06-13 05:24:30 PDT 
No blend operation performed between an SVG background image and other layers.
Comment 1 Mirela 2013-06-13 05:38:39 PDT 
Created attachment 204575 [details]
Test case
Comment 2 Mihai Tica 2013-06-13 06:05:25 PDT 
Created attachment 204577 [details]
Patch for review
Comment 3 Dirk Schulze 2013-06-13 07:46:33 PDT 
Comment on attachment 204577 [details]
Patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=204577&action=review

> Source/WebCore/svg/graphics/SVGImage.cpp:227
> +    context->setCompositeOperation(compositeOp);

Why does the composition operation needed to be reset? Why just the blend mode?
Comment 4 Mihai Tica 2013-06-13 08:57:31 PDT 
(In reply to comment #3)
> (From update of attachment 204577 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204577&action=review
> 
> > Source/WebCore/svg/graphics/SVGImage.cpp:227
> > +    context->setCompositeOperation(compositeOp);
> 
> Why does the composition operation needed to be reset? Why just the blend mode?

Thanks for reviewing this change!
This would actually reset the blend mode but it seems like it's no longer needed due to the consequent call to stateSaver.restore();
Comment 5 Mihai Tica 2013-06-13 09:53:50 PDT 
Created attachment 204624 [details]
Patch
Comment 6 Dirk Schulze 2013-06-13 10:55:37 PDT 
Comment on attachment 204624 [details]
Patch

LGTM. Great catch!
Comment 7 WebKit Commit Bot 2013-06-13 11:25:22 PDT 
Comment on attachment 204624 [details]
Patch

Clearing flags on attachment: 204624

Committed r151566: <http://trac.webkit.org/changeset/151566>
Comment 8 WebKit Commit Bot 2013-06-13 11:25:25 PDT 
All reviewed patches have been landed.  Closing bug.