Bug 117329 - [CSS Regions] Overflow areas from regions do not redraw
Summary: [CSS Regions] Overflow areas from regions do not redraw
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Radu Stavila
URL:
Keywords:
Depends on: 118665
Blocks: 116295
  Show dependency treegraph
 
Reported: 2013-06-06 18:56 PDT by Dean Jackson
Modified: 2013-11-21 09:11 PST (History)
8 users (show)

See Also:


Attachments
Reproduction (5.15 KB, text/html)
2013-06-06 18:56 PDT, Dean Jackson
no flags Details
Patch containing layout & repaint tests (10.80 KB, patch)
2013-11-13 09:11 PST, Radu Stavila
koivisto: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (498.16 KB, application/zip)
2013-11-21 07:15 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (539.61 KB, application/zip)
2013-11-21 07:21 PST, Build Bot
no flags Details
Fixed repaint test failure due to different window sizes (8.74 KB, patch)
2013-11-21 07:38 PST, Radu Stavila
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Added "reviewed by" to CL (8.74 KB, patch)
2013-11-21 08:22 PST, Radu Stavila
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-06-06 18:56:16 PDT
Created attachment 203990 [details]
Reproduction

It seems like the update rect calculation for regions is incorrect when it has visible overflow. See example.
Comment 1 Dean Jackson 2013-06-16 23:00:57 PDT
Adobe folks, is there any update on this?
Comment 2 Mihnea Ovidenie 2013-06-16 23:46:40 PDT
Yes, we are working on setting the overflow properly on regions.
Comment 3 Radu Stavila 2013-11-13 09:11:10 PST
Created attachment 216810 [details]
Patch containing layout & repaint tests

This problem has been fixed by https://bugs.webkit.org/show_bug.cgi?id=118665. After that patch lands, these new tests can be landed as well (the tests fail on the current implementation, without the 118665 patch).
Comment 4 Build Bot 2013-11-21 07:15:46 PST
Comment on attachment 216810 [details]
Patch containing layout & repaint tests

Attachment 216810 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/31768053

New failing tests:
fast/repaint/repaint-regions-overflow.html
Comment 5 Build Bot 2013-11-21 07:15:48 PST
Created attachment 217563 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2013-11-21 07:21:45 PST
Comment on attachment 216810 [details]
Patch containing layout & repaint tests

Attachment 216810 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/31758051

New failing tests:
fast/repaint/repaint-regions-overflow.html
Comment 7 Build Bot 2013-11-21 07:21:47 PST
Created attachment 217565 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 8 Radu Stavila 2013-11-21 07:38:28 PST
Created attachment 217568 [details]
Fixed repaint test failure due to different window sizes
Comment 9 WebKit Commit Bot 2013-11-21 08:18:51 PST
Comment on attachment 217568 [details]
Fixed repaint test failure due to different window sizes

Rejecting attachment 217568 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 217568, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/31518070
Comment 10 Radu Stavila 2013-11-21 08:22:54 PST
Created attachment 217572 [details]
Added "reviewed by" to CL
Comment 11 WebKit Commit Bot 2013-11-21 08:48:26 PST
Comment on attachment 217572 [details]
Added "reviewed by" to CL

Clearing flags on attachment: 217572

Committed r159628: <http://trac.webkit.org/changeset/159628>