Bug 117284 – REGRESSION (r148367): Facebook and Twitter icons at macworld.com are stacked vertically, obscuring Twitter one

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

There is a bad alignment of the symbols facebook and tweeter on top.  
FINALY AFTER MONTHS you made scrolling smooth on YAHOO page. THANKS !!!
Great programming.

[Alexey Proskuryakov]

<rdar://problem/14098607>

[Alexey Proskuryakov]

Regressed in <http://trac.webkit.org/changeset/148367>.

[Robert Hogan]

Created attachment 204089 [details]
Reduction

[Robert Hogan]

Created attachment 204090 [details]
Truer Reduction

The other one is a different bug.

[Robert Hogan]

Created attachment 204113 [details]
Patch

[Build Bot]

Comment on attachment 204113 [details]
Patch

Attachment 204113 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/764219

New failing tests:
fast/text/whitespace/inline-whitespace-wrapping-7.html
fast/text/whitespace/inline-whitespace-wrapping-5.html
fast/text/whitespace/inline-whitespace-wrapping-6.html

[Build Bot]

Created attachment 204115 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 204113 [details]
Patch

Attachment 204113 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/682446

New failing tests:
fast/text/whitespace/inline-whitespace-wrapping-7.html
fast/text/whitespace/inline-whitespace-wrapping-5.html
fast/text/whitespace/inline-whitespace-wrapping-6.html

[Build Bot]

Created attachment 204117 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Alexey Proskuryakov]

*** Bug 117393 has been marked as a duplicate of this bug. ***

[Daniel Bates]

Comment on attachment 204113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204113&action=review

> LayoutTests/fast/text/whitespace/inline-whitespace-wrapping-7-expected.html:10
> +<p> webkit.org/b/117284: Don't detect line breaks in trailing collapsing space inside nowrap inlines.</p> 

This text doesn't match the text in the test case, , LayoutTests/fast/text/whitespace/inline-whitespace-wrapping-7.html. This difference causes the test to fail as seen in the layout test results archives, say attachment 204117 [details].

> LayoutTests/fast/text/whitespace/inline-whitespace-wrapping-7-expected.html:14
> +        <a href="">B</a></div>
> +</div>

Did you intend to have two </div>s? I mean, you didn't have such </div>s in the test case?

[Robert Hogan]

Created attachment 204727 [details]
Patch

[Dave Hyatt]

Comment on attachment 204727 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 204727 [details]
Patch

Clearing flags on attachment: 204727

Committed r151613: <http://trac.webkit.org/changeset/151613>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.