Custom context menu elements implementation should be improved: - appended custom menu items should have parent menu, - appended submenu type item's menu should have a pointer to EwkViev - sub menu item should be created only using ewk_context_menu_item_new_with_submenu - item with submenu should be only of EWK_SUBMENU_TYPE
Created attachment 203194 [details] patch
Comment on attachment 203194 [details] patch Attachment 203194 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/750199 New failing tests: fast/dom/location-new-window-no-crash.html
Created attachment 203203 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Comment on attachment 203194 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=203194&action=review > Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp:99 > + if (!m_viewImpl) Should we change return type from *void* to *bool* ? See also : https://bugs.webkit.org/show_bug.cgi?id=117014#c2
Comment on attachment 203194 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=203194&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp:99 >> + if (!m_viewImpl) > > Should we change return type from *void* to *bool* ? > > See also : https://bugs.webkit.org/show_bug.cgi?id=117014#c2 I am changing it to bool here, only because of API documentation saying 'return EINA_TRUE on success or EINA_FALSE on failure', as returning true when menu is invalid (does not have pointer to EwkView), and cannot be selected, may be confusing.
Comment on attachment 203194 [details] patch Looks OK. However, someone might have a final look before landing.
Comment on attachment 203194 [details] patch LGTM.
(In reply to comment #3) > Created an attachment (id=203203) [details] > Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 > > The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. > Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3 Unrelated this patch.
Comment on attachment 203194 [details] patch Clearing flags on attachment: 203194 Committed r151162: <http://trac.webkit.org/changeset/151162>
All reviewed patches have been landed. Closing bug.