Bug 117014 – [EFL][WK2] Add a null checking condition to in hide() of EwkContextMenu

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

m_viewImpl is able to be null. So, we need to protect this function against such case.


EwkContextMenu::EwkContextMenu()
    : m_viewImpl(0)
    , m_contextMenuItems(0)
{
}

EwkContextMenu::EwkContextMenu(Eina_List* items)
    : m_viewImpl(0)
    , m_contextMenuItems(0)
{

[Gyuyoung Kim]

Created attachment 203306 [details]
Patch

[Mikhail Pozdnyakov]

Comment on attachment 203306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203306&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp:77
> +bool EwkContextMenu::hide()

I'd not change the function semantics: returned 'false' would implicitly mean that menu is not hidden which is not the case.

[Gyuyoung Kim]

Created attachment 203402 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #2)
> (From update of attachment 203306 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203306&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp:77
> > +bool EwkContextMenu::hide()
> 
> I'd not change the function semantics: returned 'false' would implicitly mean that menu is not hidden which is not the case.

Ok, I don't have big opinion about it. Changed.

[Mikhail Pozdnyakov]

Comment on attachment 203402 [details]
Patch

LGTM

[Chris Dumez]

Comment on attachment 203402 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 203402 [details]
Patch

Clearing flags on attachment: 203402

Committed r151062: <http://trac.webkit.org/changeset/151062>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.