Bug 116552 – JSC Assertion tests failures on MIPS.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Balazs Kilvady]

Many tests fails with
ASSERTION FAILED: (cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero)
webkit/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h(1626)

[Csaba Osztrogonác]

ARM traditional had a similar bug: https://bugs.webkit.org/show_bug.cgi?id=116538

[Balazs Kilvady]

Created attachment 202450 [details]
Fix branchAdd32 functions.

[Balazs Kilvady]

mozilla, SunSpider and v8 tests succeeded with this patch.

[Darin Adler]

Comment on attachment 202450 [details]
Fix branchAdd32 functions.

View in context: https://bugs.webkit.org/attachment.cgi?id=202450&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:1633
> +        // ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));

Why leave in this other assertion commented out? Please just delete it.

[Balazs Kilvady]

Created attachment 202913 [details]
Fix branchAdd32 functions.

Wrong comment removed; rebased on r150711.

[Balazs Kilvady]

Created attachment 203782 [details]
Fix branchAdd32 functions.

Rebased on r151202.

[Geoffrey Garen]

Comment on attachment 203782 [details]
Fix branchAdd32 functions.

r=me

[WebKit Commit Bot]

Comment on attachment 203782 [details]
Fix branchAdd32 functions.

Clearing flags on attachment: 203782

Committed r151228: <http://trac.webkit.org/changeset/151228>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.