Bug 116538 - JSC ARM Traditional asserting on SunSpider after r148893
Summary: JSC ARM Traditional asserting on SunSpider after r148893
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 108645 114963
  Show dependency treegraph
 
Reported: 2013-05-21 08:16 PDT by Gabor Rapcsanyi
Modified: 2013-05-21 09:43 PDT (History)
5 users (show)

See Also:


Attachments
the patch (2.97 KB, patch)
2013-05-21 08:42 PDT, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Rapcsanyi 2013-05-21 08:16:37 PDT
JSC ARM Traditional asserting on SunSpider after r148893

ASSERTION FAILED: (cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero)
/home/rgabor/WebKit/Source/JavaScriptCore/assembler/MacroAssemblerARM.h(718) : JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Jump JSC::MacroAssemblerARM::branchAdd32(JSC::MacroAssemblerARM::ResultCondition, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::TrustedImm32, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::AbsoluteAddress)
Comment 1 Mark Lam 2013-05-21 08:28:35 PDT
Looks like a simple case of needing to add "|| (cond ==PositiveOrZero)" to the branchAdd32 asserts.  Patch coming soon.
Comment 2 Mark Lam 2013-05-21 08:42:09 PDT
Created attachment 202433 [details]
the patch
Comment 3 Geoffrey Garen 2013-05-21 09:23:05 PDT
Comment on attachment 202433 [details]
the patch

r=me
Comment 4 WebKit Commit Bot 2013-05-21 09:43:36 PDT
Comment on attachment 202433 [details]
the patch

Clearing flags on attachment: 202433

Committed r150449: <http://trac.webkit.org/changeset/150449>
Comment 5 WebKit Commit Bot 2013-05-21 09:43:37 PDT
All reviewed patches have been landed.  Closing bug.