Bug 116530 - Remove custom code for webkitAudioContext global constructor getter
Summary: Remove custom code for webkitAudioContext global constructor getter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 115853
  Show dependency tree / graph
 
Reported: 2013-05-21 03:47 PDT by Chris Dumez
Modified: 2013-05-24 15:57 PDT (History)
15 users (show)

See Also:

Attachments
Patch (34.53 KB, patch)
2013-05-21 05:12 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (34.93 KB, patch)
2013-05-21 05:16 PDT, Chris Dumez 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Patch (36.23 KB, patch)
2013-05-21 05:59 PDT, Chris Dumez 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Patch (36.23 KB, patch)
2013-05-21 06:23 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (36.15 KB, patch)
2013-05-22 05:08 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-05-21 03:47:45 PDT 
webkitAudioContext global constructor getter on DOMWindow.idl currently has a [CustomGetter] because the attribute can be disabled at runtime via the WebAudioEnabled setting. We should use the RuntimeTimeEnabled class for this instead of regular settings and use [EnableAtRuntime] extended attribute so that we can automatically generate the global constructor for AudioContext.
Comment 1 Chris Dumez 2013-05-21 05:12:42 PDT 
Created attachment 202414 [details]
Patch
Comment 2 Chris Dumez 2013-05-21 05:16:43 PDT 
Created attachment 202415 [details]
Patch

Add missing WEB_AUDIO #ifdef
Comment 3 Build Bot 2013-05-21 05:49:18 PDT 
Comment on attachment 202415 [details]
Patch

Attachment 202415 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/422238
Comment 4 Chris Dumez 2013-05-21 05:59:48 PDT 
Created attachment 202419 [details]
Patch

Export extra symbol to fix mac build.
Comment 5 Build Bot 2013-05-21 06:21:54 PDT 
Comment on attachment 202419 [details]
Patch

Attachment 202419 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/516206
Comment 6 Chris Dumez 2013-05-21 06:23:52 PDT 
Created attachment 202425 [details]
Patch
Comment 7 Chris Dumez 2013-05-22 05:08:15 PDT 
Created attachment 202525 [details]
Patch

Rebase on master due to conflict with Bug 116520.
Comment 8 Gyuyoung Kim 2013-05-22 19:36:11 PDT 
Comment on attachment 202525 [details]
Patch

Looks nice refactoring. Looks fine on EFL port side.
Comment 9 Chris Dumez 2013-05-24 14:21:42 PDT 
Could someone please review this patch? Thanks.
Comment 10 Geoffrey Garen 2013-05-24 14:46:15 PDT 
Comment on attachment 202525 [details]
Patch

r=me
Comment 11 WebKit Commit Bot 2013-05-24 15:57:13 PDT 
Comment on attachment 202525 [details]
Patch

Clearing flags on attachment: 202525

Committed r150663: <http://trac.webkit.org/changeset/150663>
Comment 12 WebKit Commit Bot 2013-05-24 15:57:17 PDT 
All reviewed patches have been landed.  Closing bug.