Bug 116520 - Have IDL interface names match their global constructor
Summary: Have IDL interface names match their global constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: http://dev.w3.org/2006/webapi/WebIDL/...
Keywords:
Depends on:
Blocks: 115853
  Show dependency treegraph
 
Reported: 2013-05-21 00:55 PDT by Chris Dumez
Modified: 2013-05-22 05:04 PDT (History)
16 users (show)

See Also:


Attachments
WIP Patch (22.40 KB, patch)
2013-05-21 01:05 PDT, Chris Dumez
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (680.51 KB, application/zip)
2013-05-21 17:24 PDT, Build Bot
no flags Details
Patch (11.57 KB, patch)
2013-05-22 04:24 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-05-21 00:55:42 PDT
There are currently several IDL interfaces whose name doesn't match their global constructor attribute on DOMWindow.idl. As a result, those cannot be automatically generated.

This currently forces us to mark those interfaces as [NoInterfaceObject] which is incorrect and not according to spec.
Comment 1 Chris Dumez 2013-05-21 01:05:13 PDT
Created attachment 202396 [details]
WIP Patch
Comment 2 Build Bot 2013-05-21 17:24:12 PDT
Comment on attachment 202396 [details]
WIP Patch

Attachment 202396 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/524290

New failing tests:
fast/js/global-constructors-attributes.html
Comment 3 Build Bot 2013-05-21 17:24:14 PDT
Created attachment 202482 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 4 Chris Dumez 2013-05-22 04:24:43 PDT
Created attachment 202521 [details]
Patch
Comment 5 Kentaro Hara 2013-05-22 04:30:12 PDT
Comment on attachment 202521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202521&action=review

Looks OK.

> Source/WebCore/Modules/mediastream/MediaStream.idl:32
> +    SkipVTableValidation,

BTW, I think you can remove [SkipVTableValidation]. [ImplementationLacksVTable] and [ImplementationNamespace]. They were used in V8 binding only.
Comment 6 Chris Dumez 2013-05-22 04:33:34 PDT
Comment on attachment 202521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202521&action=review

>> Source/WebCore/Modules/mediastream/MediaStream.idl:32
>> +    SkipVTableValidation,
> 
> BTW, I think you can remove [SkipVTableValidation]. [ImplementationLacksVTable] and [ImplementationNamespace]. They were used in V8 binding only.

I quickly grep'd and it seems all 3 are used by the JSC bindings generator.
Comment 7 WebKit Commit Bot 2013-05-22 05:04:11 PDT
Comment on attachment 202521 [details]
Patch

Clearing flags on attachment: 202521

Committed r150509: <http://trac.webkit.org/changeset/150509>
Comment 8 WebKit Commit Bot 2013-05-22 05:04:16 PDT
All reviewed patches have been landed.  Closing bug.