Bug 116343 - Get rid of Custom code for Audio global constructor
Summary: Get rid of Custom code for Audio global constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 116116 116147
Blocks: 115853
  Show dependency treegraph
 
Reported: 2013-05-17 12:47 PDT by Chris Dumez
Modified: 2013-05-17 17:15 PDT (History)
10 users (show)

See Also:


Attachments
Patch (2.86 KB, patch)
2013-05-17 13:38 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
JSDOMWindow.cpp diff (1.11 KB, patch)
2013-05-17 13:38 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-05-17 12:47:16 PDT
The following DOMWindow attribute currently has a [CustomGetter]:
[CustomGetter, Conditional=VIDEO] attribute HTMLAudioElementNamedConstructor Audio; // Usable with the new operator

This should no longer be needed now that Bug 116116 and Bug 116147 were fixed.
Comment 1 Chris Dumez 2013-05-17 13:38:09 PDT
Created attachment 202149 [details]
Patch
Comment 2 Chris Dumez 2013-05-17 13:38:32 PDT
Created attachment 202150 [details]
JSDOMWindow.cpp diff
Comment 3 Geoffrey Garen 2013-05-17 14:09:58 PDT
Comment on attachment 202149 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2013-05-17 17:15:48 PDT
Comment on attachment 202149 [details]
Patch

Clearing flags on attachment: 202149

Committed r150311: <http://trac.webkit.org/changeset/150311>
Comment 5 WebKit Commit Bot 2013-05-17 17:15:51 PDT
All reviewed patches have been landed.  Closing bug.