Bug 116116 - Get rid of [CustomGetter] for global named constructors
Summary: Get rid of [CustomGetter] for global named constructors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 115853 116343
  Show dependency tree / graph
 
Reported: 2013-05-14 12:22 PDT by Chris Dumez
Modified: 2013-05-17 12:47 PDT (History)
8 users (show)

See Also:

Attachments
Patch (10.10 KB, patch)
2013-05-14 13:04 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (9.79 KB, patch)
2013-05-15 00:51 PDT, Chris Dumez 		ggaren: review+
Details | Formatted Diff | Diff
Patch for landing (9.45 KB, patch)
2013-05-17 11:33 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-05-14 12:22:08 PDT 
The JSC bindings generator should be smart enough to generate code for global named constructors. Currently those require custom code (via [CustomGetter] extended attribute).

For e.g. in DOMWindow.idl:
[CustomGetter] attribute HTMLOptionElementConstructorConstructor Option;
[CustomGetter, Conditional=VIDEO] attribute HTMLAudioElementConstructorConstructor Audio;
Comment 1 Chris Dumez 2013-05-14 13:04:00 PDT 
Created attachment 201746 [details]
Patch
Comment 2 Chris Dumez 2013-05-15 00:51:23 PDT 
Created attachment 201799 [details]
Patch
Comment 3 Chris Dumez 2013-05-15 04:35:45 PDT 
The "Audio" global constructor will be automatically generated as well once we support [EnabledAtRuntime] extended attribute for global constructors (Bug 116147).
Comment 4 Chris Dumez 2013-05-17 00:21:57 PDT 
Any feedback on this patch?
Comment 5 Kentaro Hara 2013-05-17 00:25:54 PDT 
Comment on attachment 201799 [details]
Patch

Looks correct, but JSC guys should take a look.
Comment 6 Geoffrey Garen 2013-05-17 10:51:17 PDT 
Comment on attachment 201799 [details]
Patch

r=me
Comment 7 Chris Dumez 2013-05-17 11:33:07 PDT 
Created attachment 202126 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2013-05-17 12:16:34 PDT 
Comment on attachment 202126 [details]
Patch for landing

Clearing flags on attachment: 202126

Committed r150283: <http://trac.webkit.org/changeset/150283>
Comment 9 WebKit Commit Bot 2013-05-17 12:16:38 PDT 
All reviewed patches have been landed.  Closing bug.