Bug 116109 - [Windows] Switch to embedded manifest commands for launcher executables
Summary: [Windows] Switch to embedded manifest commands for launcher executables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-14 10:36 PDT by Brent Fulgham
Modified: 2013-05-14 10:56 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.87 KB, patch)
2013-05-14 10:38 PDT, Brent Fulgham 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-05-14 10:36:01 PDT 
I recently added an external manifest file to the Windows build (see Bug 115935).  Instead, it is easier to maintain embedded manifest definitions, especially since most of our tools derive from the same DLLLauncherMain.cpp source file.

This change updates DLLLaunherMain.cpp with a conditional manifest command that instructions VS2010 (or newer) builds to select the specific VS2005 runtime used to build the various WebKitAuxiliaryLibraries and WebKitSupportLibraries components.
Comment 1 Brent Fulgham 2013-05-14 10:38:30 PDT 
Created attachment 201732 [details]
Patch
Comment 2 Darin Adler 2013-05-14 10:39:30 PDT 
Comment on attachment 201732 [details]
Patch

rs=me
Comment 3 Brent Fulgham 2013-05-14 10:56:39 PDT 
Committed r150080: <http://trac.webkit.org/changeset/150080>