WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
116109
[Windows] Switch to embedded manifest commands for launcher executables
https://bugs.webkit.org/show_bug.cgi?id=116109
Summary
[Windows] Switch to embedded manifest commands for launcher executables
Brent Fulgham
Reported
2013-05-14 10:36:01 PDT
I recently added an external manifest file to the Windows build (see
Bug 115935
). Instead, it is easier to maintain embedded manifest definitions, especially since most of our tools derive from the same DLLLauncherMain.cpp source file. This change updates DLLLaunherMain.cpp with a conditional manifest command that instructions VS2010 (or newer) builds to select the specific VS2005 runtime used to build the various WebKitAuxiliaryLibraries and WebKitSupportLibraries components.
Attachments
Patch
(2.87 KB, patch)
2013-05-14 10:38 PDT
,
Brent Fulgham
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2013-05-14 10:38:30 PDT
Created
attachment 201732
[details]
Patch
Darin Adler
Comment 2
2013-05-14 10:39:30 PDT
Comment on
attachment 201732
[details]
Patch rs=me
Brent Fulgham
Comment 3
2013-05-14 10:56:39 PDT
Committed
r150080
: <
http://trac.webkit.org/changeset/150080
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug