Bug 115935 - [Windows] Allow VS2010 Build to use VS2005 Support Libraries
Summary: [Windows] Allow VS2010 Build to use VS2005 Support Libraries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-10 14:10 PDT by Brent Fulgham
Modified: 2013-05-10 17:45 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.75 KB, patch)
2013-05-10 14:14 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (3.91 KB, patch)
2013-05-10 15:06 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-05-10 14:10:31 PDT 
Some of the non-open source libraries used by the Apple Windows build are currently built using VS2005.  These libraries link again MSVCR80.dll, but do not include a manifest that tells Windows which of the myriad of MSVCR80.dll files to use.  Consequently, Windows throws up its hands and gives up.

This patch incorporates a manifest entry in the WinLauncher tool that tells it which specific version of MSVCR80.dll it should use when trying to run.  This avoids problems when running a VS2010 WebKit build with these current support libraries.

In the future, this manifest entry could be removed.  Even if we forget, it should be harmless as long as we do not someday switch to some other MSVCR80.dll version (unlikely).
Comment 1 Brent Fulgham 2013-05-10 14:14:52 PDT 
Created attachment 201425 [details]
Patch
Comment 2 Brent Fulgham 2013-05-10 15:06:14 PDT 
Created attachment 201429 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2013-05-10 16:23:38 PDT 
<rdar://problem/13866067>
Comment 4 WebKit Commit Bot 2013-05-10 17:45:34 PDT 
Comment on attachment 201429 [details]
Patch

Clearing flags on attachment: 201429

Committed r149916: <http://trac.webkit.org/changeset/149916>
Comment 5 WebKit Commit Bot 2013-05-10 17:45:35 PDT 
All reviewed patches have been landed.  Closing bug.