Bug 115977 - Apply FINAL to the RenderObject hierarchy.
Summary: Apply FINAL to the RenderObject hierarchy.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on: 115990 116369
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-11 19:45 PDT by Andreas Kling
Modified: 2013-07-26 13:40 PDT (History)
5 users (show)

See Also:

Attachments
Snack for EWS (109.48 KB, patch)
2013-05-12 05:29 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (123.48 KB, patch)
2013-05-12 06:26 PDT, Andreas Kling 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (726.92 KB, application/zip)
2013-05-13 22:18 PDT, Build Bot 		no flags Details
Patch without devirtualization tweaks (119.93 KB, patch)
2013-05-17 11:54 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch again, now that bots are updated! (122.98 KB, patch)
2013-07-25 20:09 PDT, Andreas Kling 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Andreas Kling 2013-05-12 05:29:50 PDT 
Created attachment 201485 [details]
Snack for EWS
Comment 2 WebKit Commit Bot 2013-05-12 05:30:59 PDT 
Attachment 201485 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/RenderApplet.h', u'Source/WebCore/rendering/RenderBR.h', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderButton.h', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderCounter.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderEmbeddedObject.h', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlexibleBox.h', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFrame.h', u'Source/WebCore/rendering/RenderFrameSet.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderFullScreen.h', u'Source/WebCore/rendering/RenderGrid.h', u'Source/WebCore/rendering/RenderHTMLCanvas.h', u'Source/WebCore/rendering/RenderIFrame.h', u'Source/WebCore/rendering/RenderImage.h', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderLayerModelObject.h', u'Source/WebCore/rendering/RenderListBox.h', u'Source/WebCore/rendering/RenderListItem.h', u'Source/WebCore/rendering/RenderListMarker.h', u'Source/WebCore/rendering/RenderMedia.h', u'Source/WebCore/rendering/RenderMediaControlElements.h', u'Source/WebCore/rendering/RenderMenuList.h', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.h', u'Source/WebCore/rendering/RenderMultiColumnSet.h', u'Source/WebCore/rendering/RenderNamedFlowThread.h', u'Source/WebCore/rendering/RenderPart.h', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRegionSet.h', u'Source/WebCore/rendering/RenderReplaced.h', u'Source/WebCore/rendering/RenderReplica.h', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderScrollbarPart.h', u'Source/WebCore/rendering/RenderSearchField.h', u'Source/WebCore/rendering/RenderSlider.h', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.h', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableCol.h', u'Source/WebCore/rendering/RenderTableRow.h', u'Source/WebCore/rendering/RenderTableSection.h', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlMultiLine.h', u'Source/WebCore/rendering/RenderTextFragment.h', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderVideo.h', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderWidget.h', u'Source/WebCore/rendering/RenderWordBreak.h', u'Source/WebCore/rendering/RootInlineBox.h', u'Source/WebCore/rendering/svg/RenderSVGBlock.h', u'Source/WebCore/rendering/svg/RenderSVGContainer.h', u'Source/WebCore/rendering/svg/RenderSVGEllipse.h', u'Source/WebCore/rendering/svg/RenderSVGForeignObject.h', u'Source/WebCore/rendering/svg/RenderSVGGradientStop.h', u'Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h', u'Source/WebCore/rendering/svg/RenderSVGImage.h', u'Source/WebCore/rendering/svg/RenderSVGInline.h', u'Source/WebCore/rendering/svg/RenderSVGInlineText.h', u'Source/WebCore/rendering/svg/RenderSVGModelObject.h', u'Source/WebCore/rendering/svg/RenderSVGPath.h', u'Source/WebCore/rendering/svg/RenderSVGRect.h', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.h', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h', u'Source/WebCore/rendering/svg/RenderSVGResourceGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMarker.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.h', u'Source/WebCore/rendering/svg/RenderSVGResourcePattern.h', u'Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.h', u'Source/WebCore/rendering/svg/RenderSVGRoot.h', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/RenderSVGTSpan.h', u'Source/WebCore/rendering/svg/RenderSVGText.h', u'Source/WebCore/rendering/svg/RenderSVGTextPath.h', u'Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h', u'Source/WebCore/rendering/svg/RenderSVGViewportContainer.h']" exit_code: 1
Source/WebCore/rendering/RenderText.h:104:  The parameter name "s" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 97 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-05-12 06:26:32 PDT 
Created attachment 201486 [details]
Patch
Comment 4 WebKit Commit Bot 2013-05-12 06:29:13 PDT 
Attachment 201486 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/RenderApplet.h', u'Source/WebCore/rendering/RenderBR.h', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderButton.h', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderCounter.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderEmbeddedObject.h', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlexibleBox.h', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFrame.h', u'Source/WebCore/rendering/RenderFrameSet.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderFullScreen.h', u'Source/WebCore/rendering/RenderGrid.h', u'Source/WebCore/rendering/RenderHTMLCanvas.h', u'Source/WebCore/rendering/RenderIFrame.h', u'Source/WebCore/rendering/RenderImage.h', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderLayerModelObject.h', u'Source/WebCore/rendering/RenderListBox.h', u'Source/WebCore/rendering/RenderListItem.h', u'Source/WebCore/rendering/RenderListMarker.h', u'Source/WebCore/rendering/RenderMedia.h', u'Source/WebCore/rendering/RenderMediaControlElements.h', u'Source/WebCore/rendering/RenderMenuList.h', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.h', u'Source/WebCore/rendering/RenderMultiColumnSet.h', u'Source/WebCore/rendering/RenderNamedFlowThread.h', u'Source/WebCore/rendering/RenderPart.h', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRegionSet.h', u'Source/WebCore/rendering/RenderReplaced.h', u'Source/WebCore/rendering/RenderReplica.h', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderScrollbarPart.h', u'Source/WebCore/rendering/RenderSearchField.h', u'Source/WebCore/rendering/RenderSlider.h', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.h', u'Source/WebCore/rendering/RenderTable.h', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableCol.h', u'Source/WebCore/rendering/RenderTableRow.h', u'Source/WebCore/rendering/RenderTableSection.h', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlMultiLine.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/RenderTextFragment.h', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderVideo.h', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderWidget.h', u'Source/WebCore/rendering/RenderWordBreak.h', u'Source/WebCore/rendering/RootInlineBox.h', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.h', u'Source/WebCore/rendering/svg/RenderSVGBlock.h', u'Source/WebCore/rendering/svg/RenderSVGContainer.h', u'Source/WebCore/rendering/svg/RenderSVGEllipse.h', u'Source/WebCore/rendering/svg/RenderSVGForeignObject.h', u'Source/WebCore/rendering/svg/RenderSVGGradientStop.h', u'Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h', u'Source/WebCore/rendering/svg/RenderSVGImage.h', u'Source/WebCore/rendering/svg/RenderSVGInline.h', u'Source/WebCore/rendering/svg/RenderSVGInlineText.h', u'Source/WebCore/rendering/svg/RenderSVGModelObject.h', u'Source/WebCore/rendering/svg/RenderSVGPath.h', u'Source/WebCore/rendering/svg/RenderSVGRect.h', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.h', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h', u'Source/WebCore/rendering/svg/RenderSVGResourceGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMarker.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.h', u'Source/WebCore/rendering/svg/RenderSVGResourcePattern.h', u'Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.h', u'Source/WebCore/rendering/svg/RenderSVGRoot.h', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/RenderSVGTSpan.h', u'Source/WebCore/rendering/svg/RenderSVGText.h', u'Source/WebCore/rendering/svg/RenderSVGTextPath.h', u'Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h', u'Source/WebCore/rendering/svg/RenderSVGViewportContainer.h']" exit_code: 1
Source/WebCore/rendering/RenderText.h:104:  The parameter name "s" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 101 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Andreas Kling 2013-05-12 06:38:03 PDT 
Committed r149955: <http://trac.webkit.org/changeset/149955>
Comment 6 Simon Fraser (smfr) 2013-05-12 10:58:53 PDT 
This may have caused ~20 new test failures:
http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r149955%20(9763)/results.html
Comment 7 WebKit Commit Bot 2013-05-12 11:04:04 PDT 
Re-opened since this is blocked by bug 115990
Comment 8 Build Bot 2013-05-13 22:18:54 PDT 
Comment on attachment 201486 [details]
Patch

Attachment 201486 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/473030

New failing tests:
editing/selection/4895428-2.html
svg/hittest/svg-padding.xhtml
svg/hittest/svg-inside-table.xhtml
fast/repaint/table-hover-on-link.html
fast/table/hittest-tablecell-with-borders-right-edge.html
tables/hittesting/filltable-outline.html
fast/events/iframe-onmousemove.html
fast/dom/nodesFromRect/nodesFromRect-table.html
fast/forms/select/listbox-in-multi-column.html
tables/hittesting/filltable-emptycells.html
tables/hittesting/filltable-levels.html
tables/hittesting/filltable-stress.html
fast/writing-mode/table-hit-test.html
fast/css/nested-layers-with-hover.html
svg/hittest/svg-inside-display-table.xhtml
tables/hittesting/filltable-rtl.html
fast/forms/range/slider-in-multi-column.html
fast/table/hittest-tablecell-bottom-edge.html
fast/events/fire-mousedown-while-pressing-mouse-button.html
fast/table/hittest-tablecell-with-borders-bottom-edge.html
fast/table/hittest-tablecell-right-edge.html
Comment 9 Build Bot 2013-05-13 22:18:56 PDT 
Created attachment 201678 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 10 Andreas Kling 2013-05-17 11:54:10 PDT 
Created attachment 202131 [details]
Patch without devirtualization tweaks
Comment 11 Andreas Kling 2013-05-17 13:32:21 PDT 
Committed r150294: <http://trac.webkit.org/changeset/150294>
Comment 12 WebKit Commit Bot 2013-05-17 17:47:42 PDT 
Re-opened since this is blocked by bug 116369
Comment 13 Andreas Kling 2013-05-17 21:32:11 PDT 
This keeps breaking on the bots because they are running a buggy old version of Xcode. We'll need to update it.
Comment 14 Andreas Kling 2013-07-25 20:09:02 PDT 
Created attachment 207503 [details]
Patch again, now that bots are updated!
Comment 15 WebKit Commit Bot 2013-07-25 20:24:33 PDT 
Attachment 207503 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/RenderApplet.h', u'Source/WebCore/rendering/RenderBR.h', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderButton.h', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderCounter.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderEmbeddedObject.h', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlexibleBox.h', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFrame.h', u'Source/WebCore/rendering/RenderFrameSet.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderFullScreen.h', u'Source/WebCore/rendering/RenderGrid.h', u'Source/WebCore/rendering/RenderHTMLCanvas.h', u'Source/WebCore/rendering/RenderIFrame.h', u'Source/WebCore/rendering/RenderImage.h', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderLayerModelObject.h', u'Source/WebCore/rendering/RenderListBox.h', u'Source/WebCore/rendering/RenderListItem.h', u'Source/WebCore/rendering/RenderListMarker.h', u'Source/WebCore/rendering/RenderMedia.h', u'Source/WebCore/rendering/RenderMediaControlElements.h', u'Source/WebCore/rendering/RenderMenuList.h', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.h', u'Source/WebCore/rendering/RenderMultiColumnSet.h', u'Source/WebCore/rendering/RenderNamedFlowThread.h', u'Source/WebCore/rendering/RenderPart.h', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRegionSet.h', u'Source/WebCore/rendering/RenderReplaced.h', u'Source/WebCore/rendering/RenderReplica.h', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderScrollbarPart.h', u'Source/WebCore/rendering/RenderSearchField.h', u'Source/WebCore/rendering/RenderSlider.h', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.h', u'Source/WebCore/rendering/RenderTable.h', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableCol.h', u'Source/WebCore/rendering/RenderTableRow.h', u'Source/WebCore/rendering/RenderTableSection.h', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlMultiLine.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/RenderTextFragment.h', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderVideo.h', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderWidget.h', u'Source/WebCore/rendering/RenderWordBreak.h', u'Source/WebCore/rendering/RootInlineBox.h', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.h', u'Source/WebCore/rendering/svg/RenderSVGBlock.h', u'Source/WebCore/rendering/svg/RenderSVGContainer.h', u'Source/WebCore/rendering/svg/RenderSVGEllipse.h', u'Source/WebCore/rendering/svg/RenderSVGForeignObject.h', u'Source/WebCore/rendering/svg/RenderSVGGradientStop.h', u'Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h', u'Source/WebCore/rendering/svg/RenderSVGImage.h', u'Source/WebCore/rendering/svg/RenderSVGInline.h', u'Source/WebCore/rendering/svg/RenderSVGInlineText.h', u'Source/WebCore/rendering/svg/RenderSVGModelObject.h', u'Source/WebCore/rendering/svg/RenderSVGPath.h', u'Source/WebCore/rendering/svg/RenderSVGRect.h', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.h', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h', u'Source/WebCore/rendering/svg/RenderSVGResourceGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMarker.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.h', u'Source/WebCore/rendering/svg/RenderSVGResourcePattern.h', u'Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.h', u'Source/WebCore/rendering/svg/RenderSVGRoot.h', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/RenderSVGTSpan.h', u'Source/WebCore/rendering/svg/RenderSVGText.h', u'Source/WebCore/rendering/svg/RenderSVGTextPath.h', u'Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h', u'Source/WebCore/rendering/svg/RenderSVGViewportContainer.h']" exit_code: 1
Source/WebCore/rendering/RenderText.h:104:  The parameter name "s" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 101 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 Simon Fraser (smfr) 2013-07-26 08:50:29 PDT 
Can you mail webkit-dev explaining FINAL (and reminding on OVERRIDE) once this lands?
Comment 17 Andreas Kling 2013-07-26 09:03:47 PDT 
(In reply to comment #16)
> Can you mail webkit-dev explaining FINAL (and reminding on OVERRIDE) once this lands?

Will do.
Comment 18 WebKit Commit Bot 2013-07-26 13:34:54 PDT 
Comment on attachment 207503 [details]
Patch again, now that bots are updated!

Rejecting attachment 207503 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 207503, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/1250312
Comment 19 Andreas Kling 2013-07-26 13:40:50 PDT 
Committed r153380: <http://trac.webkit.org/changeset/153380>