Bug 115942 - fourthTier: FTL should support Jump and ForceOSRExit
Summary: fourthTier: FTL should support Jump and ForceOSRExit
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Blocks: 112840
  Show dependency treegraph
Reported: 2013-05-10 16:12 PDT by Filip Pizlo
Modified: 2013-05-11 14:07 PDT (History)
7 users (show)

See Also:

work in progress (9.15 KB, patch)
2013-05-10 16:13 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (12.46 KB, patch)
2013-05-11 10:21 PDT, Filip Pizlo
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-05-10 16:12:30 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2013-05-10 16:13:04 PDT
Created attachment 201435 [details]
work in progress

This makes v8-raytrace fail.  Will investigate why.
Comment 2 Filip Pizlo 2013-05-11 10:21:27 PDT
Created attachment 201461 [details]
the patch
Comment 3 Filip Pizlo 2013-05-11 10:22:41 PDT
Comment on attachment 201461 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201461&action=review

> Source/JavaScriptCore/ftl/FTLCapabilities.cpp:91
> +        case Array::ForceExit:
> +            return true;

Note, this is the reason why this code was moved into a separate function: I wanted to be able to treat ForceExit as being OK immediately; and there was no easy way to do it with the way the control flow was nested previously.
Comment 4 Filip Pizlo 2013-05-11 14:07:28 PDT
Landed in http://trac.webkit.org/changeset/149941