Bug 115626 - JSC ARM traditional failing on Octane NavierStokes test
Summary: JSC ARM traditional failing on Octane NavierStokes test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 108645
  Show dependency tree / graph
 
Reported: 2013-05-06 01:43 PDT by Gabor Rapcsanyi
Modified: 2013-06-12 22:57 PDT (History)
4 users (show)

See Also:

Attachments
proposed fix (1.34 KB, patch)
2013-05-06 04:10 PDT, Gabor Rapcsanyi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Rapcsanyi 2013-05-06 01:43:57 PDT 
JSC ARM traditional failing on Octane NavierStokes test
Comment 1 Gabor Rapcsanyi 2013-05-06 04:10:50 PDT 
Created attachment 200653 [details]
proposed fix
Comment 2 WebKit Commit Bot 2013-05-06 04:13:04 PDT 
Attachment 200653 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/ARMAssembler.h']" exit_code: 1
Source/JavaScriptCore/assembler/ARMAssembler.h:166:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:167:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zoltan Herczeg 2013-05-06 08:55:56 PDT 
Comment on attachment 200653 [details]
proposed fix

r=me
Comment 4 WebKit Commit Bot 2013-05-06 09:36:52 PDT 
Comment on attachment 200653 [details]
proposed fix

Clearing flags on attachment: 200653

Committed r149601: <http://trac.webkit.org/changeset/149601>
Comment 5 WebKit Commit Bot 2013-05-06 09:36:54 PDT 
All reviewed patches have been landed.  Closing bug.