Bug 115235 - [Qt] REGRESSION(r149001): It made two fast/dom/DeviceMotion tests fail.
Summary: [Qt] REGRESSION(r149001): It made two fast/dom/DeviceMotion tests fail.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 110573
Blocks: 79666
  Show dependency tree / graph
 
Reported: 2013-04-26 01:32 PDT by Ádám Kallai
Modified: 2013-04-26 02:15 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.56 KB, patch)
2013-04-26 01:44 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ádám Kallai 2013-04-26 01:32:04 PDT 
* fast/dom/DeviceMotion/window-property.html
diff:

--- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/DeviceMotion/window-property-expected.txt
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/DeviceMotion/window-property-actual.txt
@@ -5,7 +5,7 @@
 
 PASS typeof window.DeviceMotionEvent == 'object' is true
 PASS typeof window.DeviceMotionEvent == 'function' is false
-PASS hasDeviceMotionEventProperty() is true
+FAIL hasDeviceMotionEventProperty() should be true. Was false.
 PASS 'DeviceMotionEvent' in window is true
 PASS window.hasOwnProperty('DeviceMotionEvent') is true
 PASS typeof window.ondevicemotion == 'object' is true

 * fast/dom/DeviceOrientation/window-property.html
diff:

--- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/DeviceOrientation/window-property-expected.txt
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/dom/DeviceOrientation/window-property-actual.txt
@@ -5,7 +5,7 @@
 
 PASS typeof window.DeviceOrientationEvent == 'object' is true
 PASS typeof window.DeviceOrientationEvent == 'function' is false
-PASS hasDeviceOrientationEventProperty() is true
+FAIL hasDeviceOrientationEventProperty() should be true. Was false.
 PASS 'DeviceOrientationEvent' in window is true
 PASS window.hasOwnProperty('DeviceOrientationEvent') is true
 PASS typeof window.ondeviceorientation == 'object' is true
Comment 1 Ádám Kallai 2013-04-26 01:33:02 PDT 
Could you check what happened to it, please?
Comment 2 Chris Dumez 2013-04-26 01:34:08 PDT 
I'm on it.
Comment 3 Chris Dumez 2013-04-26 01:44:41 PDT 
Created attachment 199802 [details]
Patch

Sorry about that, those tests are skipped on EFL so I did not notice the failure.
Comment 4 Kentaro Hara 2013-04-26 01:48:10 PDT 
Comment on attachment 199802 [details]
Patch

Thanks for the quick fix!
Comment 5 WebKit Commit Bot 2013-04-26 02:15:29 PDT 
Comment on attachment 199802 [details]
Patch

Clearing flags on attachment: 199802

Committed r149171: <http://trac.webkit.org/changeset/149171>
Comment 6 WebKit Commit Bot 2013-04-26 02:15:32 PDT 
All reviewed patches have been landed.  Closing bug.