Bug 115135 - WebProcess is crashing on http://achicu.github.io/css-presentation when direct pattern compositing is enabled
Summary: WebProcess is crashing on http://achicu.github.io/css-presentation when direc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-24 15:48 PDT by WebKit Commit Bot
Modified: 2013-05-24 09:34 PDT (History)
9 users (show)

See Also:

Attachments
GDB Stack trace (9.41 KB, application/octet-stream)
2013-04-25 10:40 PDT, Sergio Correia (qrwteyrutiyoup) 		no flags Details
Patch (5.81 KB, patch)
2013-05-09 15:09 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Patch (13.97 KB, patch)
2013-05-09 15:15 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Patch (5.86 KB, patch)
2013-05-09 15:43 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Patch for landing (4.20 KB, patch)
2013-05-24 09:05 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Patch for landing (5.68 KB, patch)
2013-05-24 09:06 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2013-04-24 15:48:40 PDT 
[Qt][WK2] WebProcess is crashing on http://achicu.github.io/css-presentation
Requested by rafaelbrandao on #webkit.
Comment 1 Sergio Correia (qrwteyrutiyoup) 2013-04-25 10:40:20 PDT 
This regression seems to be caused by https://bugs.webkit.org/show_bug.cgi?id=109588, or at least git bisect thinks so :)
Comment 2 Sergio Correia (qrwteyrutiyoup) 2013-04-25 10:40:51 PDT 
Created attachment 199685 [details]
GDB Stack trace
Comment 3 Noam Rosenthal 2013-05-09 15:09:37 PDT 
Created attachment 201285 [details]
Patch
Comment 4 Noam Rosenthal 2013-05-09 15:15:58 PDT 
Created attachment 201287 [details]
Patch
Comment 5 Benjamin Poulain 2013-05-09 15:37:40 PDT 
This is only common code. Why is this marked [Qt][EFL]?
Comment 6 Noam Rosenthal 2013-05-09 15:40:36 PDT 
(In reply to comment #5)
> This is only common code. Why is this marked [Qt][EFL]?
I think when the bug was reported it wasn't clear that the problem was in common code, since that common code is currently activated only in coordinated graphics.
Comment 7 Noam Rosenthal 2013-05-09 15:43:57 PDT 
Created attachment 201294 [details]
Patch
Comment 8 Antti Koivisto 2013-05-24 08:37:24 PDT 
Comment on attachment 201294 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201294&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:1477
> +    CachedImage* cachedImage = style->backgroundLayers()->image()->cachedImage();
> +    ASSERT(cachedImage);
> +
> +    RefPtr<Image> image = cachedImage->image();

This assertion seems unnecessary. Calling without null checking already communicates that the pointer is expected not to be null and we are going to get a clean crash anyway if it not.
Comment 9 Noam Rosenthal 2013-05-24 09:05:16 PDT 
Created attachment 202825 [details]
Patch for landing
Comment 10 Noam Rosenthal 2013-05-24 09:06:20 PDT 
Created attachment 202826 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2013-05-24 09:34:28 PDT 
Comment on attachment 202826 [details]
Patch for landing

Clearing flags on attachment: 202826

Committed r150643: <http://trac.webkit.org/changeset/150643>
Comment 12 WebKit Commit Bot 2013-05-24 09:34:32 PDT 
All reviewed patches have been landed.  Closing bug.