Bug 114808 – [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andras Becsi]

http://trac.webkit.org/changeset/131727 introduced a workaround to speed up layout tests on buildbots running in Xvfb.
This workaround depended on QQuickWindowPrivate::setRenderWithoutShowing which has been removed from QtDeclarative in https://codereview.qt-project.org/53880, thus we have to find a new solution for this problem.

[Jocelyn Turcotte]

What?
Maybe they didn't know we used it, it's not really dead code.

[Andras Becsi]

Created attachment 200704 [details]
Patch

[Andras Becsi]

(In reply to comment #2)
> Created an attachment (id=200704) [details]
> Patch

This probably needs a Qt version update on the bots.

[Jocelyn Turcotte]

Comment on attachment 200704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200704&action=review

> Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp:69
> +            // Remove this as soon as we depend on Qt 5.1

I think you can omit the comment, it won't be necessary to remove it before we completely stop supporting Qt 5.0 in trunk.

[Andras Becsi]

Created attachment 200708 [details]
Patch

[Andras Becsi]

Comment on attachment 200708 [details]
Patch

Ossy, feel free to land this if it is not causing issues for the pixel testing bot, since I'm not sure what version of Qt 5 is used there.

[Andras Becsi]

Comment on attachment 200708 [details]
Patch

Clearing flags on attachment: 200708

Committed r149667: <http://trac.webkit.org/changeset/149667>

[Andras Becsi]

All reviewed patches have been landed.  Closing bug.