Bug 114612 - REGRESSION(r148378): editing/style/block-style-005.html failing
Summary: REGRESSION(r148378): editing/style/block-style-005.html failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 128245 (view as bug list)
Depends on:
Blocks: 79666 110979
  Show dependency tree / graph
 
Reported: 2013-04-15 02:30 PDT by Zoltan Arvai
Modified: 2014-02-07 02:47 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.78 KB, patch)
2014-02-06 23:47 PST, Lukasz Bialek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Arvai 2013-04-15 02:30:53 PDT 
After r148378 editing/style/block-style-005.html failing on Qt and GTK:

--- /ramdisk/qt-linux-release/build/layout-test-results/editing/style/block-style-005-expected.txt
+++ /ramdisk/qt-linux-release/build/layout-test-results/editing/style/block-style-005-actual.txt
@@ -1,9 +1,8 @@
 You should see one "x" followed by two blank lines. The blank lines should be the same height. The second line must be the same height as the first. See: <rdar://problem/3959727> REGRESSION (Mail): Style not preserved on blank lines
 x
-
-
+x
 execInsertParagraphCommand: <div id="test" class="editing">x</div><div id="test" class="editing"><br></div>
 execInsertParagraphCommand: <div id="test" class="editing">x</div><div id="test" class="editing"><br></div><div id="test" class="editing"><br></div>
 execTypeCharacterCommand: <div id="test" class="editing">x</div><div id="test" class="editing"><br></div><div id="test" class="editing">x</div>
 execFontSizeCommand: <div id="test" class="editing"><font size="7">x</font></div><div id="test" class="editing"><font size="7"><br></font></div><div id="test" class="editing"><font size="7">x</font></div>
-execDeleteCommand: <div id="test" class="editing"><font size="7">x</font></div><div id="test" class="editing"><font size="7"><br></font></div><div id="test" class="editing"><br></div>
+execDeleteCommand: <div id="test" class="editing"><font size="7">x</font></div><div id="test" class="editing"><span style="font-size: -webkit-xxx-large;">x</span></div>
Comment 1 Zoltan Arvai 2013-04-15 07:18:01 PDT 
Test skipped on Qt in http://trac.webkit.org/changeset/148436.
Please unksip it with proper fix.
Comment 2 Lukasz Bialek 2014-02-06 07:10:35 PST 
*** Bug 128245 has been marked as a duplicate of this bug. ***
Comment 3 Alexey Proskuryakov 2014-02-06 09:31:22 PST 
This test is still failing on Gtk and Efl, and it's skipped on Windows via bug 116564. Appears to pass on Mac.
Comment 4 Lukasz Bialek 2014-02-06 23:47:20 PST 
Created attachment 223430 [details]
Patch

This patch fixes the test on EFL and GTK ports.
Comment 5 WebKit Commit Bot 2014-02-07 02:47:14 PST 
Comment on attachment 223430 [details]
Patch

Clearing flags on attachment: 223430

Committed r163620: <http://trac.webkit.org/changeset/163620>
Comment 6 WebKit Commit Bot 2014-02-07 02:47:18 PST 
All reviewed patches have been landed.  Closing bug.