Bug 114580 – Implement JIT for MinGW-w64 64-bit

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Jonathan Liu]

https://bugs.webkit.org/show_bug.cgi?id=107965 implements JIT for MSVC 64-bit but not MinGW-w64 64-bit.

[Jonathan Liu]

This may be useful for reference:
http://sourceforge.net/apps/trac/mingw-w64/wiki/MinGW%20x64%20Software%20convention

[Allan Sandfeld Jensen]

(In reply to comment #1)
> This may be useful for reference:
> http://sourceforge.net/apps/trac/mingw-w64/wiki/MinGW%20x64%20Software%20convention

Isn't that the same calling convention?

Perhaps you just need to find a place where COMPILER(MSVC) is used where COMPILER(MINGW64) needs to be added.

[Jonathan Liu]

(In reply to comment #2)
> Isn't that the same calling convention?
> 
> Perhaps you just need to find a place where COMPILER(MSVC) is used where COMPILER(MINGW64) needs to be added.

It appears the calling convention are the same, but we will need an implementation of the trampoline functions in GCC inline asm.

[Jonathan Liu]

Created attachment 197986 [details]
Patch

[WebKit Commit Bot]

Attachment 197986 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/JITStubs.cpp']" exit_code: 1
Source/JavaScriptCore/jit/JITStubs.cpp:449:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/jit/JITStubs.cpp:486:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/jit/JITStubs.cpp:488:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/jit/JITStubs.cpp:495:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/jit/JITStubs.cpp:497:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/jit/JITStubs.cpp:509:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jonathan Liu]

Created attachment 197988 [details]
Patch

[WebKit Commit Bot]

Attachment 197988 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/JITStubs.cpp']" exit_code: 1
Source/JavaScriptCore/jit/JITStubs.cpp:454:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/jit/JITStubs.cpp:491:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/jit/JITStubs.cpp:493:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/jit/JITStubs.cpp:500:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/jit/JITStubs.cpp:502:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/jit/JITStubs.cpp:514:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jonathan Liu]

Created attachment 197989 [details]
Patch

[WebKit Commit Bot]

Attachment 197989 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/JITStubs.cpp']" exit_code: 1
Source/JavaScriptCore/jit/JITStubs.cpp:447:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/jit/JITStubs.cpp:484:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/jit/JITStubs.cpp:486:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/jit/JITStubs.cpp:493:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/jit/JITStubs.cpp:495:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/jit/JITStubs.cpp:507:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jocelyn Turcotte]

Comment on attachment 197989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197989&action=review

> Source/JavaScriptCore/jit/JITStubs.cpp:509
> +#elif COMPILER(MSVC) && CPU(X86_64) && OS(WINDOWS)

As far as I know MSVC is only used to build for Windows, no need to add an extra check.

[Jonathan Liu]

Created attachment 198042 [details]
Patch

[WebKit Commit Bot]

Attachment 198042 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/JITStubs.cpp']" exit_code: 1
Source/JavaScriptCore/jit/JITStubs.cpp:447:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/jit/JITStubs.cpp:484:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/jit/JITStubs.cpp:486:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/jit/JITStubs.cpp:493:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/jit/JITStubs.cpp:495:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/jit/JITStubs.cpp:507:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jocelyn Turcotte]

Comment on attachment 198042 [details]
Patch

I'm no expert generally in JavaScriptCore but this patch is pretty straigthforward, so r=me.

[WebKit Commit Bot]

Comment on attachment 198042 [details]
Patch

Clearing flags on attachment: 198042

Committed r148663: <http://trac.webkit.org/changeset/148663>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.