Bug 107965 – Implement JIT on Windows 64 bits

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jocelyn Turcotte]

Implement JIT on Windows 64 bits

[Jocelyn Turcotte]

Created attachment 184780 [details]
Patch

[WebKit Review Bot]

Attachment 184780 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/jit/JITStubs.h', u'Source/JavaScriptCore/jit/JITStubsMSVC64.asm', u'Source/JavaScriptCore/jit/JSInterfaceJIT.h', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp', u'Source/JavaScriptCore/yarr/YarrJIT.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h']" exit_code: 1
Source/JavaScriptCore/jit/ThunkGenerators.cpp:281:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Hausmann]

Comment on attachment 184780 [details]
Patch

Patch LGTM (and I'm familiar with amd64 :)

Geoffrey, Filip, are you okay with this going in?

[Jocelyn Turcotte]

Created attachment 189076 [details]
Patch

Remove trailing semicolons from JITStubsMSVC64.asm as advised by Zoltan.

[WebKit Review Bot]

Attachment 189076 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/jit/JITStubs.h', u'Source/JavaScriptCore/jit/JITStubsMSVC64.asm', u'Source/JavaScriptCore/jit/JSInterfaceJIT.h', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp', u'Source/JavaScriptCore/yarr/YarrJIT.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h']" exit_code: 1
Source/JavaScriptCore/jit/ThunkGenerators.cpp:281:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Comment on attachment 189076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189076&action=review

Lgtm also but I want a good answer for the license issue before we proceed.

> Source/JavaScriptCore/jit/JITStubsMSVC64.asm:4
> +;    This library is free software; you can redistribute it and/or

We strongly prefer the 2-clause BSD license for all new code. Is there a specific reason why you are using LGPL?

[Jocelyn Turcotte]

Created attachment 189302 [details]
Patch

(In reply to comment #6)
> We strongly prefer the 2-clause BSD license for all new code. Is there a specific reason why you are using LGPL?

No reason, I was just not aware that we have a preference.
Here's new patch using BSD instead.

[WebKit Review Bot]

Attachment 189302 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/jit/JITStubs.h', u'Source/JavaScriptCore/jit/JITStubsMSVC64.asm', u'Source/JavaScriptCore/jit/JSInterfaceJIT.h', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp', u'Source/JavaScriptCore/yarr/YarrJIT.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h']" exit_code: 1
Source/JavaScriptCore/jit/ThunkGenerators.cpp:281:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jocelyn Turcotte]

Created attachment 190053 [details]
Patch

Something went wrong with the last upload, trying again.

[WebKit Review Bot]

Attachment 190053 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/jit/JITStubs.h', u'Source/JavaScriptCore/jit/JITStubsMSVC64.asm', u'Source/JavaScriptCore/jit/JSInterfaceJIT.h', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp', u'Source/JavaScriptCore/yarr/YarrJIT.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h']" exit_code: 1
Source/JavaScriptCore/jit/ThunkGenerators.cpp:281:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jocelyn Turcotte]

Committed r144043: <http://trac.webkit.org/changeset/144043>