Bug 107965 - Implement JIT on Windows 64 bits
Summary: Implement JIT on Windows 64 bits
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-25 11:16 PST by Jocelyn Turcotte
Modified: 2013-02-26 05:06 PST (History)
11 users (show)

See Also:

Attachments
Patch (14.18 KB, patch)
2013-01-25 11:27 PST, Jocelyn Turcotte 		no flags Details | Formatted Diff | Diff
Patch (14.11 KB, patch)
2013-02-19 06:29 PST, Jocelyn Turcotte 		no flags Details | Formatted Diff | Diff
Patch (14.18 KB, patch)
2013-02-20 06:11 PST, Jocelyn Turcotte 		no flags Details | Formatted Diff | Diff
Patch (14.55 KB, patch)
2013-02-25 07:22 PST, Jocelyn Turcotte 		hausmann: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2013-01-25 11:16:53 PST 
Implement JIT on Windows 64 bits
Comment 1 Jocelyn Turcotte 2013-01-25 11:27:13 PST 
Created attachment 184780 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-25 11:29:19 PST 
Attachment 184780 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/jit/JITStubs.h', u'Source/JavaScriptCore/jit/JITStubsMSVC64.asm', u'Source/JavaScriptCore/jit/JSInterfaceJIT.h', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp', u'Source/JavaScriptCore/yarr/YarrJIT.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h']" exit_code: 1
Source/JavaScriptCore/jit/ThunkGenerators.cpp:281:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Hausmann 2013-02-19 00:37:15 PST 
Comment on attachment 184780 [details]
Patch

Patch LGTM (and I'm familiar with amd64 :)

Geoffrey, Filip, are you okay with this going in?
Comment 4 Jocelyn Turcotte 2013-02-19 06:29:33 PST 
Created attachment 189076 [details]
Patch

Remove trailing semicolons from JITStubsMSVC64.asm as advised by Zoltan.
Comment 5 WebKit Review Bot 2013-02-19 06:37:42 PST 
Attachment 189076 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/jit/JITStubs.h', u'Source/JavaScriptCore/jit/JITStubsMSVC64.asm', u'Source/JavaScriptCore/jit/JSInterfaceJIT.h', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp', u'Source/JavaScriptCore/yarr/YarrJIT.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h']" exit_code: 1
Source/JavaScriptCore/jit/ThunkGenerators.cpp:281:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Filip Pizlo 2013-02-19 10:26:48 PST 
Comment on attachment 189076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189076&action=review

Lgtm also but I want a good answer for the license issue before we proceed.

> Source/JavaScriptCore/jit/JITStubsMSVC64.asm:4
> +;    This library is free software; you can redistribute it and/or

We strongly prefer the 2-clause BSD license for all new code. Is there a specific reason why you are using LGPL?
Comment 7 Jocelyn Turcotte 2013-02-20 06:11:11 PST 
Created attachment 189302 [details]
Patch

(In reply to comment #6)
> We strongly prefer the 2-clause BSD license for all new code. Is there a specific reason why you are using LGPL?

No reason, I was just not aware that we have a preference.
Here's new patch using BSD instead.
Comment 8 WebKit Review Bot 2013-02-20 06:13:22 PST 
Attachment 189302 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/jit/JITStubs.h', u'Source/JavaScriptCore/jit/JITStubsMSVC64.asm', u'Source/JavaScriptCore/jit/JSInterfaceJIT.h', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp', u'Source/JavaScriptCore/yarr/YarrJIT.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h']" exit_code: 1
Source/JavaScriptCore/jit/ThunkGenerators.cpp:281:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Jocelyn Turcotte 2013-02-25 07:22:57 PST 
Created attachment 190053 [details]
Patch

Something went wrong with the last upload, trying again.
Comment 10 WebKit Review Bot 2013-02-25 07:26:20 PST 
Attachment 190053 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/jit/JITStubs.h', u'Source/JavaScriptCore/jit/JITStubsMSVC64.asm', u'Source/JavaScriptCore/jit/JSInterfaceJIT.h', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp', u'Source/JavaScriptCore/yarr/YarrJIT.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h']" exit_code: 1
Source/JavaScriptCore/jit/ThunkGenerators.cpp:281:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Jocelyn Turcotte 2013-02-26 05:06:27 PST 
Committed r144043: <http://trac.webkit.org/changeset/144043>