Bug 114455 – [CSS Shaders] Parse the parameters descriptor

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dirk Schulze]

Parse the parameters descriptor of the filter at-rule.

[Michelangelo De Simone]

*** This bug has been marked as a duplicate of bug 113565 ***

[Dirk Schulze]

Created attachment 197651 [details]
Patch for parameters.

[Dirk Schulze]

The other bug is a dup.

[Dirk Schulze]

Created attachment 197652 [details]
Patch for parameters.

[Dirk Schulze]

*** Bug 113565 has been marked as a duplicate of this bug. ***

[Michelangelo De Simone]

(In reply to comment #3)

> The other bug is a dup.

I'm confident you saw the date and performed a search before opening this new bug and getting to this conclusion.

[Dirk Schulze]

(In reply to comment #6)
> (In reply to comment #3)
> 
> > The other bug is a dup.
> 
> I'm confident you saw the date and performed a search before opening this new bug and getting to this conclusion.

And I am sure you know that I don't care.

[Dean Jackson]

Comment on attachment 197652 [details]
Patch for parameters. 

View in context: https://bugs.webkit.org/attachment.cgi?id=197652&action=review

> Source/WebCore/ChangeLog:9
> +        parametrization of CSS Shaders.

typo: parameterization (although I'm not sure it is a real word anyway :)

[Dirk Schulze]

Created attachment 197655 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 197655 [details]
Patch for landing.

Clearing flags on attachment: 197655

Committed r148227: <http://trac.webkit.org/changeset/148227>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

It seems like this patch broke ietestcenter/css3/grid/grid-items-003.htm ?

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ietestcenter%2Fcss3%2Fgrid%2Fgrid-items-003.htm

[Ryosuke Niwa]

(In reply to comment #12)
> It seems like this patch broke ietestcenter/css3/grid/grid-items-003.htm ?
> 
> http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ietestcenter%2Fcss3%2Fgrid%2Fgrid-items-003.htm

(In reply to comment #12)
> It seems like this patch broke ietestcenter/css3/grid/grid-items-003.htm ?
> 
> http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ietestcenter%2Fcss3%2Fgrid%2Fgrid-items-003.htm

I guess not. It's probably caused by the slave reboot. Sorry for the noise.