Bug 114438 – Compile assert failure for JITStackFrame assembly trampoline

• Status: RESOLVED
• Resolution: INVALID
• Component: JavaScriptCore

[Jonathan Liu]

Building QtWebKit in Qt 5.1 (qt5 stable branch):

..\WTF/wtf/Assertions.h:328:74: error: size of array 'dummyJITStackFrame_callFrame_offset_matches_ctiTrampoline' is negative
 #define COMPILE_ASSERT(exp, name) typedef int dummy##name [(exp) ? 1 : -1]
                                                                          ^
jit\JITStubs.cpp:371:1: note: in expansion of macro 'COMPILE_ASSERT'
 COMPILE_ASSERT(offsetof(struct JITStackFrame, callFrame) == 0x58, JITStackFrame_callFrame_offset_matches_ctiTrampoline);
 ^
..\WTF/wtf/Assertions.h:328:74: error: size of array 'dummyJITStackFrame_code_offset_matches_ctiTrampoline' is negative
 #define COMPILE_ASSERT(exp, name) typedef int dummy##name [(exp) ? 1 : -1]
                                                                          ^
jit\JITStubs.cpp:372:1: note: in expansion of macro 'COMPILE_ASSERT'
 COMPILE_ASSERT(offsetof(struct JITStackFrame, code) == 0x48, JITStackFrame_code_offset_matches_ctiTrampoline);
 ^
..\WTF/wtf/Assertions.h:328:74: error: size of array 'dummyJITStackFrame_stub_argument_space_matches_ctiTrampoline' is negative
 #define COMPILE_ASSERT(exp, name) typedef int dummy##name [(exp) ? 1 : -1]
                                                                          ^
jit\JITStubs.cpp:373:1: note: in expansion of macro 'COMPILE_ASSERT'
 COMPILE_ASSERT(offsetof(struct JITStackFrame, savedRBX) == 0x78, JITStackFrame_stub_argument_space_matches_ctiTrampoline);
 ^

Compiler: MinGW-w64 GCC 4.8.0 64-bit POSIX Threading, SEH Exception Handling (MinGW-builds)

[Jonathan Liu]

Created attachment 197981 [details]
Patch

[Allan Sandfeld Jensen]

Have you tried changing line 367 in JITStubs.cpp:
from:#if COMPILER(GCC) && CPU(X86_64)
to:#if COMPILER(GCC) && CPU(X86_64) && !OS(WINDOWS)
and below 
from:#elif COMPILER(MSVC) && CPU(X86_64)
to:#elif OS(WINDOWS) && CPU(X86_64)

Calling convensions should be the same. The ifdefs just seems to assume GCC means SysV calling convension and MSVC is needed for windows.

[Jonathan Liu]

This will be fixed by implementing JIT for MinGW-w64 64-bit - https://bugs.webkit.org/show_bug.cgi?id=114580

[Mark Hahnenberg]

Comment on attachment 197981 [details]
Patch

Clearing review flag since it's been resolved.