Bug 114418 - [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
Summary: [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaseline...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Glenn Adams
URL:
Keywords:
Depends on: 114410
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-11 00:42 PDT by Glenn Adams
Modified: 2013-04-11 01:25 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.28 KB, patch)
2013-04-11 00:47 PDT, Glenn Adams 		no flags Details | Formatted Diff | Diff
Patch for landing (4.29 KB, patch)
2013-04-11 00:55 PDT, Glenn Adams 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Glenn Adams 2013-04-11 00:42:07 PDT 
Complete removal of SCM.add() optional return_exit_code from scm_mock and rebaselineserver. Change rebaselineserver to catch ScriptError in order to determine failure and exit_code.
Comment 1 Glenn Adams 2013-04-11 00:47:15 PDT 
Created attachment 197516 [details]
Patch
Comment 2 Ryosuke Niwa 2013-04-11 00:48:39 PDT 
Comment on attachment 197516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197516&action=review

> Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py:121
> +        except ScriptError, e:

Please don't use one-letter variable name like e. Spell out error.

> Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py:157
> +        except ScriptError, e:

Ditto.
Comment 3 Glenn Adams 2013-04-11 00:55:05 PDT 
Created attachment 197518 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2013-04-11 01:25:41 PDT 
Comment on attachment 197518 [details]
Patch for landing

Clearing flags on attachment: 197518

Committed r148183: <http://trac.webkit.org/changeset/148183>
Comment 5 WebKit Commit Bot 2013-04-11 01:25:43 PDT 
All reviewed patches have been landed.  Closing bug.