RESOLVED FIXED114418
[webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver. 
https://bugs.webkit.org/show_bug.cgi?id=114418
Summary [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaseline...
Glenn Adams
Reported 2013-04-11 00:42:07 PDT
Complete removal of SCM.add() optional return_exit_code from scm_mock and rebaselineserver. Change rebaselineserver to catch ScriptError in order to determine failure and exit_code.
Attachments
Patch (4.28 KB, patch)
2013-04-11 00:47 PDT, Glenn Adams 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.29 KB, patch)
2013-04-11 00:55 PDT, Glenn Adams 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Glenn Adams
Comment 1 2013-04-11 00:47:15 PDT
Created attachment 197516 [details] Patch
Ryosuke Niwa
Comment 2 2013-04-11 00:48:39 PDT
Comment on attachment 197516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197516&action=review > Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py:121 > + except ScriptError, e: Please don't use one-letter variable name like e. Spell out error. > Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py:157 > + except ScriptError, e: Ditto.
Glenn Adams
Comment 3 2013-04-11 00:55:05 PDT
Created attachment 197518 [details] Patch for landing
WebKit Commit Bot
Comment 4 2013-04-11 01:25:41 PDT
Comment on attachment 197518 [details] Patch for landing Clearing flags on attachment: 197518 Committed r148183: <http://trac.webkit.org/changeset/148183>
WebKit Commit Bot
Comment 5 2013-04-11 01:25:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.