Bug 114410 - [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
Summary: [webkitpy] Remove unused return_exit_code argument and returned values from S...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Glenn Adams
URL:
Keywords:
Depends on:
Blocks: 114386 114418
  Show dependency tree / graph
 
Reported: 2013-04-10 22:25 PDT by Glenn Adams
Modified: 2013-04-11 00:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.32 KB, patch)
2013-04-10 22:30 PDT, Glenn Adams 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Glenn Adams 2013-04-10 22:25:26 PDT 
No caller of SCM.add or SCM.add_list (or its overrides in SVN/GIT) make use of their return value or specify True for return_exit_code. Simplify these methods by removing the return_exit_code argument and return values.
Comment 1 Glenn Adams 2013-04-10 22:30:03 PDT 
Created attachment 197506 [details]
Patch
Comment 2 WebKit Commit Bot 2013-04-10 23:03:03 PDT 
Comment on attachment 197506 [details]
Patch

Clearing flags on attachment: 197506

Committed r148173: <http://trac.webkit.org/changeset/148173>
Comment 3 WebKit Commit Bot 2013-04-10 23:03:05 PDT 
All reviewed patches have been landed.  Closing bug.