The WebCore::enableSecureTextInput and WebCore::disableSecureTextInput methods are/were Chromium-specific and should as such now be removed.
Created attachment 196851 [details] Patch
Comment on attachment 196851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196851&action=review > Source/WebCore/html/PasswordInputType.cpp:105 > void PasswordInputType::handleFocusEvent(Node* oldFocusedNode, FocusDirection direction) > { > BaseTextInputType::handleFocusEvent(oldFocusedNode, direction); > - if (element()->document()->frame()) > - element()->document()->setUseSecureKeyboardEntryWhenActive(true); > } > > void PasswordInputType::handleBlurEvent() > { > - if (element()->document()->frame()) > - element()->document()->setUseSecureKeyboardEntryWhenActive(false); > BaseTextInputType::handleBlurEvent(); You should remove PasswordInputType::handleFocusEvent and handleBlurEvent entirely.
Created attachment 196853 [details] Patch Thanks for the review, here's the updated patch.
Comment on attachment 196853 [details] Patch Attachment 196853 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17492025
Comment on attachment 196853 [details] Patch Attachment 196853 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17449071
Comment on attachment 196853 [details] Patch Attachment 196853 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17536023
Created attachment 196855 [details] Patch
Comment on attachment 196855 [details] Patch Clearing flags on attachment: 196855 Committed r147920: <http://trac.webkit.org/changeset/147920>
All reviewed patches have been landed. Closing bug.