Bug 114126 - Remove WebCore::(enable|disable)SecureTextInput methods
Summary: Remove WebCore::(enable|disable)SecureTextInput methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on: 114081
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-07 12:00 PDT by Zan Dobersek
Modified: 2013-04-08 09:49 PDT (History)
7 users (show)

See Also:


Attachments
Patch (10.10 KB, patch)
2013-04-08 06:46 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (10.74 KB, patch)
2013-04-08 07:15 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (15.40 KB, patch)
2013-04-08 07:35 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-04-07 12:00:31 PDT
The WebCore::enableSecureTextInput and WebCore::disableSecureTextInput methods are/were Chromium-specific and should as such now be removed.
Comment 1 Zan Dobersek 2013-04-08 06:46:48 PDT
Created attachment 196851 [details]
Patch
Comment 2 Kent Tamura 2013-04-08 07:05:23 PDT
Comment on attachment 196851 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196851&action=review

> Source/WebCore/html/PasswordInputType.cpp:105
>  void PasswordInputType::handleFocusEvent(Node* oldFocusedNode, FocusDirection direction)
>  {
>      BaseTextInputType::handleFocusEvent(oldFocusedNode, direction);
> -    if (element()->document()->frame())
> -        element()->document()->setUseSecureKeyboardEntryWhenActive(true);
>  }
>  
>  void PasswordInputType::handleBlurEvent()
>  {
> -    if (element()->document()->frame())
> -        element()->document()->setUseSecureKeyboardEntryWhenActive(false);
>      BaseTextInputType::handleBlurEvent();

You should remove PasswordInputType::handleFocusEvent and handleBlurEvent entirely.
Comment 3 Zan Dobersek 2013-04-08 07:15:55 PDT
Created attachment 196853 [details]
Patch

Thanks for the review, here's the updated patch.
Comment 4 Early Warning System Bot 2013-04-08 07:25:33 PDT
Comment on attachment 196853 [details]
Patch

Attachment 196853 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17492025
Comment 5 Early Warning System Bot 2013-04-08 07:27:19 PDT
Comment on attachment 196853 [details]
Patch

Attachment 196853 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17449071
Comment 6 EFL EWS Bot 2013-04-08 07:31:54 PDT
Comment on attachment 196853 [details]
Patch

Attachment 196853 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17536023
Comment 7 Zan Dobersek 2013-04-08 07:35:53 PDT
Created attachment 196855 [details]
Patch
Comment 8 Zan Dobersek 2013-04-08 09:49:26 PDT
Comment on attachment 196855 [details]
Patch

Clearing flags on attachment: 196855

Committed r147920: <http://trac.webkit.org/changeset/147920>
Comment 9 Zan Dobersek 2013-04-08 09:49:31 PDT
All reviewed patches have been landed.  Closing bug.