Bug 114081 – Remove remaining PLATFORM(CHROMIUM)-guarded code in WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

Remove remaining PLATFORM(CHROMIUM)-guarded code in WebCore

[Zan Dobersek]

Created attachment 196719 [details]
Patch

[EFL EWS Bot]

Comment on attachment 196719 [details]
Patch

Attachment 196719 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17528345

[Early Warning System Bot]

Comment on attachment 196719 [details]
Patch

Attachment 196719 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17523337

[Early Warning System Bot]

Comment on attachment 196719 [details]
Patch

Attachment 196719 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17527343

[Build Bot]

Comment on attachment 196719 [details]
Patch

Attachment 196719 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17442449

[Build Bot]

Comment on attachment 196719 [details]
Patch

Attachment 196719 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17524355

[Zan Dobersek]

Created attachment 196726 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 196719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196719&action=review

> Source/WebCore/platform/SecureTextInput.cpp:33
>  void enableSecureTextInput()

I think we should just get rid of these functions.

> Source/WebCore/platform/graphics/FloatPoint.h:158
> +#if PLATFORM(MA) && !defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES)

Typo: MA.

> Source/WebCore/platform/graphics/GlyphBuffer.h:42
> +#if OS(DARWIN) && (PLATFORM(WX)

Typo: Unmatched (

> Source/WebCore/platform/leveldb/LevelDBDatabase.cpp:140
>  static void histogramFreeSpace(const char* type, String fileName)

We should probably get rid of this function altogether.

[Early Warning System Bot]

Comment on attachment 196726 [details]
Patch

Attachment 196726 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17446367

[Early Warning System Bot]

Comment on attachment 196726 [details]
Patch

Attachment 196726 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17472427

[EFL EWS Bot]

Comment on attachment 196726 [details]
Patch

Attachment 196726 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17486474

[Build Bot]

Comment on attachment 196726 [details]
Patch

Attachment 196726 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17420531

[Build Bot]

Comment on attachment 196726 [details]
Patch

Attachment 196726 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17509022

[Zan Dobersek]

Comment on attachment 196719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196719&action=review

>> Source/WebCore/platform/SecureTextInput.cpp:33
>>  void enableSecureTextInput()
> 
> I think we should just get rid of these functions.

These are called in FrameSelection::setUseSecureKeyboardEntry[1]. Should I remove all the code paths that lead to that method as well? I'd be more comfortable doing that in a separate patch, though.

[1] http://trac.webkit.org/browser/trunk/Source/WebCore/editing/FrameSelection.cpp#L1730

[Ryosuke Niwa]

(In reply to comment #14)
> (From update of attachment 196719 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196719&action=review
> 
> >> Source/WebCore/platform/SecureTextInput.cpp:33
> >>  void enableSecureTextInput()
> > 
> > I think we should just get rid of these functions.
> 
> These are called in FrameSelection::setUseSecureKeyboardEntry[1]. Should I remove all the code paths that lead to that method as well? I'd be more comfortable doing that in a separate patch, though.

Can we add a FIXME or something?  Or maybe leave that PLATFORM(CHROMIUm) alone and delete in a follow up patch. I'm concerned that we'll forget about them and never get to clean them up.

[Zan Dobersek]

Created attachment 196800 [details]
Patch

[Build Bot]

Comment on attachment 196800 [details]
Patch

Attachment 196800 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17486864

[Zan Dobersek]

Created attachment 196812 [details]
Patch

[Benjamin Poulain]

Comment on attachment 196812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196812&action=review

Brilliant!

> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:181
> +#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(EFL) || PLATFORM(BLACKBERRY) || PLATFORM(WIN)

I wonder if that should be a
    #if !PLATFORM(QT)

(in a separate patch).

> Source/WebCore/platform/leveldb/LevelDBDatabase.cpp:38
>  #include "Logging.h"
> +#include "NotImplemented.h"
>  #include <helpers/memenv/memenv.h>

??

[Benjamin Poulain]

Comment on attachment 196812 [details]
Patch

Clearing flags on attachment: 196812

Committed r147888: <http://trac.webkit.org/changeset/147888>

[Benjamin Poulain]

All reviewed patches have been landed.  Closing bug.