Bug 114124 – [WK2][GTK] Make WK2 C API headers compile in the GTK build on Windows

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: WebKit2

[Kalev Lember]

Similar to https://bugs.webkit.org/show_bug.cgi?id=96246 , we don't want to include WKBase.h and WKAPICast.h in the GTK Windows build, these files are specific to the Safari/Windows port.

[Kalev Lember]

Created attachment 196796 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 196796 [details]
Patch

Rejecting attachment 196796 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 196796, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
3.
patching file Source/WebKit2/Shared/API/c/WKBase.h
Hunk #1 FAILED at 29.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/Shared/API/c/WKBase.h.rej
patching file Source/WebKit2/UIProcess/API/C/WKAPICast.h
Hunk #1 FAILED at 409.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/C/WKAPICast.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Martin Robinson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/45340

[Kalev Lember]

Looks like during the time that passed between the r+ and the cq+, another change has landed that removed the conditional windows includes altogether.

http://trac.webkit.org/changeset/147963