Bug 96246 - [WK2] Make WK2 C API headers compile in the Qt build on Windows
Summary: [WK2] Make WK2 C API headers compile in the Qt build on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Hausmann
URL:
Keywords:
Depends on:
Blocks: 76776
  Show dependency tree / graph
 
Reported: 2012-09-10 01:41 PDT by Simon Hausmann
Modified: 2012-09-10 02:09 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.07 KB, patch)
2012-09-10 01:43 PDT, Simon Hausmann 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2012-09-10 01:41:38 PDT 
[WK2] Make WK2 C API headers compile in the Qt build on Windows
Comment 1 Simon Hausmann 2012-09-10 01:43:51 PDT 
Created attachment 163067 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-09-10 01:49:44 PDT 
Comment on attachment 163067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163067&action=review

> Source/WebKit2/Shared/API/c/WKBase.h:32
> +#if (defined(WIN32) || defined(_WIN32)) && !defined(BUILDING_QT__)

This couldn't be PLATFORM(WIN) && instead?
Comment 3 Simon Hausmann 2012-09-10 02:05:01 PDT 
Comment on attachment 163067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163067&action=review

>> Source/WebKit2/Shared/API/c/WKBase.h:32
>> +#if (defined(WIN32) || defined(_WIN32)) && !defined(BUILDING_QT__)
> 
> This couldn't be PLATFORM(WIN) && instead?

Unfortunately no, as that would require including config.h and WTF's Platform.h, both of which are not available when these header files are used on the application side.
Comment 4 WebKit Review Bot 2012-09-10 02:09:02 PDT 
Comment on attachment 163067 [details]
Patch

Clearing flags on attachment: 163067

Committed r128033: <http://trac.webkit.org/changeset/128033>
Comment 5 WebKit Review Bot 2012-09-10 02:09:05 PDT 
All reviewed patches have been landed.  Closing bug.